AP_AdvancedFailsafe: option to not go back to the loss comm mission item if we are already in the return path #29961
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
May 9, 2025
|
Thanks Peter. I have been super busy. I'll look into this. |
eppravitra
force-pushed
the
afs-improvement
branch
from
64bcce8 to
f99d8a6
Compare
|
Hi @peterbarker , Please see the changes. I have a very specific case where I still require a direct comparison of mission item numbers. However, I have implemented what you suggested. There are now two options that can handle both cases. Am I right that I should check for the return path instead of the landing sequence? |
peterbarker
requested changes
May 12, 2025
…tem if we already in the return path
eppravitra
force-pushed
the
afs-improvement
branch
from
f99d8a6 to
7776686
Compare
eppravitra
changed the title
eppravitra
changed the title
|
Hi @peterbarker, Please see my latest attempt. |
|
@peterbarker , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if there is a loss comm., the aircraft will always fly to the mission item specified with AFS_WP_COMMS.
I added an option so that if we have already passed AFS_WP_COMMS and got a loss. We should not go back to AFS_WP_COMMS.
This is useful, for example, if the aircraft is already in the landing sequence. If there is a loss during a landing attempt, it should just land instead of starting the landing sequence again.
I tested the change with Gazebo SITL.