-
Notifications
You must be signed in to change notification settings - Fork 18.6k
AP_Mount: XFRobot pic-in-pic switch #29720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @Ferruccio1984, Thanks very much for this! Could you update the commit title to start with "AP_Mount:" and put "XFRobot" in there somewhere too? This will help make backporting easy and we do it for all commits. Just to be clear, I mean the commit title, not the PR title. Thanks! |
Hi @Ferruccio1984, I've checked the API and it seems that the PIC_IN_PIC command might accept the desired pic-in-pic mode. I wonder if you've tried setting the "param" argument to values besides 0x00 to see what happens? For example perhaps "1" is RGB, "2" is IR and 3 is Picture-in-picture? |
Ping @Ferruccio1984 - answer requested. |
Hi @peterbarker, Sorry, I talked with @Ferruccio1984 offline and he's looking into this I think |
Hi @peterbarker , been working on it and talking to @rmackay9 on Discord. Will update the pr soon. Thank you! |
replace previous camera toggle/cycling implementation
make modes nomenclature and ordering consistent with other gimbal models
Adds capability of toggling between pic-in-pic modes using camera lens auxiliary function.
Tested on XF-Robot Z-2 micro gimbal