Skip to content

AP_Logger: Ensure that the units are specified accurately #29719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Apr 7, 2025

This value is converted to bytes using 1024 as the divisor. Therefore, the unit is KiB.

WIKI:
https://en.wikipedia.org/wiki/Kilobyte

@tpwrules
Copy link
Contributor

tpwrules commented Apr 8, 2025

I like the idea though!

@rmackay9
Copy link
Contributor

Txs. It would be good to squash the commits together into a single commit.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muramura please squash the commits together

@peterbarker peterbarker force-pushed the AP_Ensure_that_the_units_are_specified_accurately branch from c2f8ca3 to a544b7e Compare May 9, 2025 11:47
@peterbarker
Copy link
Contributor

peterbarker commented May 9, 2025

I've rebased this / squashed the commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants