Skip to content

[Fix]: add missing await #8936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

[Fix]: add missing await #8936

merged 1 commit into from
Jun 5, 2025

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Jun 5, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.


Summarize what the PR does, explaining any non-trivial design decisions.
I'm seeing this in the logs

/Users/rohitmalhotra/Library/Caches/pypoetry/virtualenvs/openhands-ai-71T_-94H-py3.12/lib/python3.12/site-packages/fastapi/dependencies/utils.py:638: RuntimeWarning: coroutine 'get_user_id' was never awaited
  solved = await call(**solved_result.values)
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

This PR just adds the missing await

Bug was introduced in #8899

Link of any specific issues this addresses:


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:59902ea-nikolaik   --name openhands-app-59902ea   docker.all-hands.dev/all-hands-ai/openhands:59902ea

@malhotra5 malhotra5 enabled auto-merge (squash) June 5, 2025 21:46
@malhotra5 malhotra5 merged commit 336b22b into main Jun 5, 2025
19 checks passed
@malhotra5 malhotra5 deleted the fix-await branch June 5, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants