Assorted fixes for the nested / docker runtimes. #8899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality this introduces.
This PR improves the stability and reliability of nested and Docker runtimes in OpenHands, particularly when handling container lifecycle and conversation management. It fixes issues with container reuse, file paths, and error handling that could cause problems when starting, stopping, or restarting conversations.
Summarize what the PR does, explaining any non-trivial design decisions.
Improved container management:
Fixed file path for nested conversations:
/root/openhands/file_store/
to/root/.openhands/file_store/
to ensure proper file storage and accessImproved error handling:
remove()
todiscard()
for the_starting_conversation_ids
set to prevent KeyError exceptionsAdded configuration for sandbox close delay:
close_delay
is 0 or NoneSANDBOX_CLOSE_DELAY
to "0" for nested containers to prevent premature cleanupCode simplification:
get_user_id()
functionLink of any specific issues this addresses: