Skip to content

Remove global config from tests #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Jul 20, 2024

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

This PR removes the global config file from a few remaining tests.

Other references

Part of #2758

Copy link
Collaborator

@yufansong yufansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yufansong yufansong merged commit 04877f8 into main Jul 21, 2024
2 checks passed
@yufansong yufansong deleted the neubig/remove_config_from_tests branch July 21, 2024 03:07
@tobitege
Copy link
Collaborator

Hello @neubig ,
I'm surprised this got merged without below test failing. 🤔

poetry run pytest -svvv ./tests/test_fileops.py

runs into error because the signature of files.resolve_path was changed in #3039 .

    def test_resolve_path():
>       assert (
            files.resolve_path('test.txt', '/workspace')
            == Path(WORKSPACE_BASE) / 'test.txt'
        )
E       TypeError: resolve_path() missing 2 required positional arguments: 'workspace_base' and 'workspace_mount_path_in_sandbox'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants