Skip to content

Remove config from files #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Remove config from files #3039

merged 1 commit into from
Jul 20, 2024

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Jul 19, 2024

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?

Removes global config from files.py.

Other references

Part of #2758

Copy link
Collaborator

@iFurySt iFurySt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@neubig neubig merged commit dada004 into main Jul 20, 2024
2 checks passed
@neubig neubig deleted the neubig/remove_config_from_files branch July 20, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants