Skip to content

Fix failed test_browse_internet CodeActAgent integration prompts #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix failed test_browse_internet CodeActAgent integration prompts #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/mock/CodeActAgent/test_browse_internet/prompt_001.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,4 +311,4 @@ NOW, LET'S START!

Browse localhost:8000, and tell me the ultimate answer to life. Do not ask me for confirmation at any point.

ENVIRONMENT REMINDER: You have 9 turns left to complete the task.
ENVIRONMENT REMINDER: You have 9 turns left to complete the task.
2 changes: 1 addition & 1 deletion tests/integration/mock/CodeActAgent/test_browse_internet/prompt_002.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,4 @@ Here is an example with chain of thought of a valid action when clicking on a bu
"
In order to accomplish my goal I need to click on the button with bid 12
```click("12")```
"
"
7 changes: 3 additions & 4 deletions tests/integration/mock/CodeActAgent/test_browse_internet/prompt_003.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,13 @@ RootWebArea 'The Ultimate Answer', focused
[8] heading 'The Ultimate Answer'
[9] paragraph ''
StaticText 'Click the button to reveal the answer to life, the universe, and everything.'
[10] button 'Click me'
[10] button 'Click me', clickable

# Previous Actions
goto('http://localhost:8000')

noop()

Here is an example with chain of thought of a valid action when clicking on a button:
"
In order to accomplish my goal I need to click on the button with bid 12
```click("12")```
"
"
7 changes: 3 additions & 4 deletions tests/integration/mock/CodeActAgent/test_browse_internet/prompt_004.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,15 @@ RootWebArea 'The Ultimate Answer', focused
[8] heading 'The Ultimate Answer'
[9] paragraph ''
StaticText 'Click the button to reveal the answer to life, the universe, and everything.'
[10] button 'Click me', focused
[10] button 'Click me', clickable, focused
StaticText 'The answer is OpenDevin is all you need!'

# Previous Actions
goto('http://localhost:8000')
noop()
click("10")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems strange. The noop() is indeed present as long as we have a couple of lines in browsing agent sending an extra-action at the start, to get the first browser obs. But why is it missing the goto? That needs to happen anyway, doesn't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks strange, I think need to check the change in #2103

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's due to #2103 but this indeed looks strange. Since CI is failing let's merge this first. I'll take a look later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's from https://github.com/OpenDevin/OpenDevin/pull/2170/files#r1630346264



Here is an example with chain of thought of a valid action when clicking on a button:
"
In order to accomplish my goal I need to click on the button with bid 12
```click("12")```
"
"
2 changes: 1 addition & 1 deletion tests/integration/mock/CodeActAgent/test_browse_internet/prompt_005.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,4 +316,4 @@ Browse localhost:8000, and tell me the ultimate answer to life. Do not ask me fo
OBSERVATION:
{'content': 'The answer to life, the universe, and everything is: OpenDevin is all you need!'}

ENVIRONMENT REMINDER: You have 8 turns left to complete the task.
ENVIRONMENT REMINDER: You have 8 turns left to complete the task.