Skip to content

Fix failed test_browse_internet CodeActAgent integration prompts #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

yufansong
Copy link
Collaborator

@yufansong yufansong commented Jun 7, 2024

Fix failed integration test. Introduced by #2103 foget to merge main.

@enyst
Copy link
Collaborator

enyst commented Jun 7, 2024

I think it's fixed here: #2307

StaticText 'The answer is OpenDevin is all you need!'

# Previous Actions
goto('http://localhost:8000')
noop()
click("10")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems strange. The noop() is indeed present as long as we have a couple of lines in browsing agent sending an extra-action at the start, to get the first browser obs. But why is it missing the goto? That needs to happen anyway, doesn't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks strange, I think need to check the change in #2103

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's due to #2103 but this indeed looks strange. Since CI is failing let's merge this first. I'll take a look later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yufansong
Copy link
Collaborator Author

I think it's fixed here: #2307

I prefer to open this PR to discuss the problem. Then after it get merged, other PR can merge main to avoid code confusion for other PR reviewer.

StaticText 'The answer is OpenDevin is all you need!'

# Previous Actions
goto('http://localhost:8000')
noop()
click("10")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's due to #2103 but this indeed looks strange. Since CI is failing let's merge this first. I'll take a look later.

@li-boxuan li-boxuan merged commit 6aba337 into main Jun 7, 2024
2 checks passed
@li-boxuan li-boxuan deleted the yufan/fix branch June 7, 2024 16:22
@enyst
Copy link
Collaborator

enyst commented Jun 7, 2024

I'm a bit confused what happened here, sorry, I think the other PR was on auto-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants