-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix failed test_browse_internet CodeActAgent integration prompts #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think it's fixed here: #2307 |
StaticText 'The answer is OpenDevin is all you need!' | ||
|
||
# Previous Actions | ||
goto('http://localhost:8000') | ||
noop() | ||
click("10") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems strange. The noop() is indeed present as long as we have a couple of lines in browsing agent sending an extra-action at the start, to get the first browser obs. But why is it missing the goto
? That needs to happen anyway, doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks strange, I think need to check the change in #2103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's due to #2103 but this indeed looks strange. Since CI is failing let's merge this first. I'll take a look later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's from https://github.com/OpenDevin/OpenDevin/pull/2170/files#r1630346264
I prefer to open this PR to discuss the problem. Then after it get merged, other PR can merge main to avoid code confusion for other PR reviewer. |
StaticText 'The answer is OpenDevin is all you need!' | ||
|
||
# Previous Actions | ||
goto('http://localhost:8000') | ||
noop() | ||
click("10") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's due to #2103 but this indeed looks strange. Since CI is failing let's merge this first. I'll take a look later.
I'm a bit confused what happened here, sorry, I think the other PR was on auto-merge. |
Fix failed integration test. Introduced by #2103 foget to merge main.