Skip to content

test(a3p-integration): update to agoric-upgrade-20 #11426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

test(a3p-integration): update to agoric-upgrade-20 #11426

merged 2 commits into from
May 30, 2025

Conversation

mujahidkay
Copy link
Member

Description

Agoric/agoric-3-proposals#251

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

tested in a3p

Upgrade Considerations

None

@mujahidkay mujahidkay requested a review from a team as a code owner May 29, 2025 17:58
@mujahidkay mujahidkay requested a review from AgoricTriage May 29, 2025 17:58
@mujahidkay mujahidkay self-assigned this May 29, 2025
Copy link

cloudflare-workers-and-pages bot commented May 29, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: e606c33
Status: ✅  Deploy successful!
Preview URL: https://4dcef125.agoric-sdk.pages.dev
Branch Preview URL: https://mk-add-u20.agoric-sdk.pages.dev

View logs

@mujahidkay mujahidkay added the force:integration Force integration tests to run on PR label May 29, 2025
@mujahidkay mujahidkay requested a review from mhofman May 29, 2025 18:06
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to merge once you clean up the test files no longer needed.

@@ -8,7 +8,6 @@
},
"type": "Software Upgrade Proposal",
"sdk-generate": [
"testing/add-USD-LEMONS.js test/generated/addUsdLemons",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the files in a3p-integration/proposals/n:upgrade-next/test/depositUSD-LEMONS as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I somehow missed it.

@mujahidkay mujahidkay added the automerge:rebase Automatically rebase updates, then merge label May 30, 2025
@mergify mergify bot merged commit 7564f29 into master May 30, 2025
86 of 89 checks passed
@mergify mergify bot deleted the mk/add-u20 branch May 30, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants