-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add agoric-upgrade-20 (proposal 95) #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
5790907
to
30fa850
Compare
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
}, | ||
"resolutions": { | ||
"protobufjs@npm:^6.8.8": "patch:protobufjs@npm%3A6.11.4#~/.yarn/patches/protobufjs-npm-6.11.4-af11968b80.patch", | ||
"axios@npm:^1.6.0": "patch:axios@npm%3A1.7.7#~/.yarn/patches/axios-npm-1.7.7-cfbedc233d.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pray that someday we won't need these patches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the generated files were not successfully ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure but I recall the CI failing without generated files. So I explicitly added them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah my bad, agoric-3-proposals doesn't have a way to generate from agoric-sdk ...
The .gitignore
probably shouldn't include those then
## Description Agoric/agoric-3-proposals#251 ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None ### Testing Considerations tested in a3p ### Upgrade Considerations None
adopt a passed proposal
When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks.
fromTag
usinglatest
(such as a3p-integration) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up)use-${proposalName}
(where proposalName is the part of the agoric-3-proposals proposal directory name after the colon, cf. a3p-integration/proposals)