chore: do not write chain info to vstorage #11312

0xpatrickdev · 2025-04-22T17:02:48Z

closes: #11310

Description

prefer decentral-itest-orchestration-config.json to decentral-itest-orchestration-chains-config.json in boot and multichain-testing tests
ensure all example contracts provide their own chainInfo in proposal builder opts
eliminate all* reliance on chain info being written to vstorage, except for packages/boot/test/orchestration/vstorage-chain-info.test.ts which explicitly tests this functionality
- * note: ChainHub still uses vstorage to lookup chainInfo if none is found until ChainHub methods should be sync #10602. After ChainHub methods should be sync #10602 the failure will be the same - ~Error: chain not found:agoric - but won't involve a remote call to agoricNames.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Updates existing tests. Preserves vstorage tests in a new file - packages/boot/test/orchestration/vstorage-chain-info.test.ts

Upgrade Considerations

None, contract changes in the PR are only for example contracts.

cloudflare-workers-and-pages · 2025-04-22T17:05:21Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`743a0ce`
Status:	✅ Deploy successful!
Preview URL:	https://514dc5ef.agoric-sdk.pages.dev
Branch Preview URL:	https://11310-remove-chain-info-from.agoric-sdk.pages.dev

View logs

dckc · 2025-04-22T18:49:03Z

packages/builders/scripts/testing/start-query-flows.js

+  const parseChainInfo = () => {
+    if (typeof chainInfo !== 'string') return undefined;
+    return JSON.parse(chainInfo);
+  };
+  const parseAssetInfo = () => {
+    if (typeof assetInfo !== 'string') return undefined;
+    return JSON.parse(assetInfo);
+  };
+  const opts = harden({
+    chainInfo: parseChainInfo(),
+    assetInfo: parseAssetInfo(),
+  });


this bit is getting repeated a lot. consider factoring it out

+1 but I won't block on it

Good idea, added a parseChainHubOpts helper

turadg · 2025-04-22T18:49:54Z

.github/workflows/multichain-e2e-template.yml

@@ -110,10 +110,6 @@ jobs:
          make fund-provision-pool
        working-directory: ./agoric-sdk/multichain-testing

-      - name: Override Chain Registry


this should save some time too

turadg · 2025-04-22T18:51:51Z

packages/builders/scripts/testing/start-query-flows.js

+  const parseChainInfo = () => {
+    if (typeof chainInfo !== 'string') return undefined;
+    return JSON.parse(chainInfo);
+  };
+  const parseAssetInfo = () => {
+    if (typeof assetInfo !== 'string') return undefined;
+    return JSON.parse(assetInfo);
+  };
+  const opts = harden({
+    chainInfo: parseChainInfo(),
+    assetInfo: parseAssetInfo(),
+  });


+1 but I won't block on it

dckc

looks good, presuming tests still passed.

I don't see any production code changes so I reviewed the commits somewhat quickly.

dckc · 2025-04-22T18:50:27Z

packages/orchestration/src/proposals/start-stakeAtom.js

+export const startStakeAtom = async (
+  {


odd whitespace change. makes this part of the diff a little harder to read

The change here and in startStakeOsmo, startStakeBld is incorporating the second argument, options

dckc · 2025-04-22T18:51:26Z

packages/orchestration/src/proposals/start-stakeBld.js

+export const startStakeBld = async (
+  {


again, I'm struggling to see what the substance of this change is

dckc · 2025-04-22T18:53:44Z

packages/builders/scripts/orchestration/init-stakeBld.js

        },
+        options,


are the options the same on all these example contracts? if so, I wonder about a common builder with an arg to pick which core eval to build

More or less, yes. I didn't go with a common builder (yet) but added a parseChainHubOpts helper

dckc · 2025-04-22T18:55:47Z

packages/builders/scripts/testing/start-query-flows.js

@@ -7,7 +7,6 @@
 import { deeplyFulfilledObject, makeTracer } from '@agoric/internal';
 import { makeStorageNodeChild } from '@agoric/internal/src/lib-chainStorage.js';
 import { E } from '@endo/far';
-import { parseArgs } from 'node:util';


I wonder how this worked before

It never did - it was a part of a change introduced in this PR. I probably could've fixed up to avoid misleading here.

0xpatrickdev force-pushed the 11310-remove-chain-info-from-vstorage branch from 5e384f8 to be51f72 Compare April 22, 2025 17:05

0xpatrickdev added the force:integration Force integration tests to run on PR label Apr 22, 2025

0xpatrickdev force-pushed the 11310-remove-chain-info-from-vstorage branch 3 times, most recently from 008d9b0 to 44880e8 Compare April 22, 2025 18:43

0xpatrickdev marked this pull request as ready for review April 22, 2025 18:43

0xpatrickdev requested a review from a team as a code owner April 22, 2025 18:43

0xpatrickdev requested review from AgoricTriage, turadg and dckc April 22, 2025 18:43

dckc reviewed Apr 22, 2025

View reviewed changes

turadg approved these changes Apr 22, 2025

View reviewed changes

dckc approved these changes Apr 22, 2025

View reviewed changes

0xpatrickdev added 2 commits April 22, 2025 17:03

chore: remove override-chain-registry step

09f59d9

chore: prefer orchestration config w/o vstorage chain info

afc3cd2

0xpatrickdev force-pushed the 11310-remove-chain-info-from-vstorage branch from ab60c44 to 3ce3903 Compare April 22, 2025 21:03

0xpatrickdev added the automerge:rebase Automatically rebase updates, then merge label Apr 22, 2025

refactor: separate chain info vstorage tests

11ff38b

0xpatrickdev force-pushed the 11310-remove-chain-info-from-vstorage branch from 3ce3903 to ca0f832 Compare April 22, 2025 21:16

0xpatrickdev added 4 commits April 22, 2025 17:46

chore: example contracts register their own chain info

bcff198

refactor: connection info lookup

e0710e8

refactor: dynamically import node:util

a67203a

refactor: parseChainHubOpts helper

743a0ce

0xpatrickdev force-pushed the 11310-remove-chain-info-from-vstorage branch from ca0f832 to 743a0ce Compare April 22, 2025 21:47

mergify bot merged commit f8c06e6 into master Apr 22, 2025
90 checks passed

mergify bot deleted the 11310-remove-chain-info-from-vstorage branch April 22, 2025 22:18

dckc mentioned this pull request May 19, 2025

chore(orchestration): create scaffold for swap anything asyncFlow #11304

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: do not write chain info to vstorage #11312

chore: do not write chain info to vstorage #11312

0xpatrickdev commented Apr 22, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Apr 22, 2025 •

edited

Loading

Uh oh!

dckc Apr 22, 2025

Uh oh!

turadg Apr 22, 2025

Uh oh!

0xpatrickdev Apr 22, 2025

Uh oh!

turadg Apr 22, 2025

Uh oh!

turadg Apr 22, 2025

Uh oh!

dckc left a comment

Uh oh!

dckc Apr 22, 2025

Uh oh!

0xpatrickdev Apr 22, 2025

Uh oh!

dckc Apr 22, 2025

Uh oh!

dckc Apr 22, 2025

Uh oh!

0xpatrickdev Apr 22, 2025

Uh oh!

dckc Apr 22, 2025

Uh oh!

0xpatrickdev Apr 22, 2025

Uh oh!

Uh oh!

Uh oh!

chore: do not write chain info to vstorage #11312

chore: do not write chain info to vstorage #11312

Conversation

0xpatrickdev commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Uh oh!

cloudflare-workers-and-pages bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying agoric-sdk with Cloudflare Pages

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dckc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

0xpatrickdev commented Apr 22, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Apr 22, 2025 •

edited

Loading