Skip to content

do not write chainInfo to vstorage in testing environments #11310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xpatrickdev opened this issue Apr 22, 2025 · 0 comments · Fixed by #11312
Closed

do not write chainInfo to vstorage in testing environments #11310

0xpatrickdev opened this issue Apr 22, 2025 · 0 comments · Fixed by #11312

Comments

@0xpatrickdev
Copy link
Contributor

0xpatrickdev commented Apr 22, 2025

What

Testing environments publish agoricNames.chainConnection and agoricNames.chain by way of write-chain-info.js. This was to facilitate early chainHub designs where consumers could provide their own chain info or fallback to agoricNames for a lookup.

Since we've yet to run write-chain-info.js on mainnet, and may not have plans to (see #10602), we should remove this configuration.

Why

So testing environments resemble mainnet and code isn't accidentally reliant on an API that's not in mainnet.

How

  1. prefer decentral-itest-orchestration-config.json to packages/vm-config/decentral-itest-orchestration-chains-config.json (no write-chain-info.js)
  2. ensure test/example contracts that currently depend on lookupChainInfo in ChainHub pre-register their own chain info
  3. do not call override-chain-info in multichain-testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant