Skip to content

Pip upgrade before launch #9358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Manjiz
Copy link

@Manjiz Manjiz commented Apr 4, 2023

Please read the contributing wiki page before submitting a pull request!

If you have a large change, pay special attention to this paragraph:

Before making changes, if you think that your feature will result in more than 100 lines changing, find me and talk to me about the feature you are proposing. It pains me to reject the hard work someone else did, but I won't add everything to the repo, and it's better if the rejection happens before you have to waste time working on the feature.

Otherwise, after making sure you're following the rules described in wiki page, remove this section and continue on.

Describe what this pull request is trying to achieve.

A clear and concise description of what you're trying to accomplish with this, so your intent doesn't have to be extracted from your code.

Additional notes and description of your changes

More technical discussion about your changes go here, plus anything that a maintainer might have to specifically take a look at, or be wary of.

Environment this was tested in

List the environment you have developed / tested this on. As per the contributing page, changes should be able to work on Windows out of the box.

  • OS: [e.g. Windows, Linux]
  • Browser: [e.g. chrome, safari]
  • Graphics card: [e.g. NVIDIA RTX 2080 8GB, AMD RX 6600 8GB]

Screenshots or videos of your changes

If applicable, screenshots or a video showing off your changes. If it edits an existing UI, it should ideally contain a comparison of what used to be there, before your changes were made.

This is required for anything that touches the user interface.

@Manjiz Manjiz requested a review from AUTOMATIC1111 as a code owner April 4, 2023 12:16
@Manjiz
Copy link
Author

Manjiz commented Apr 4, 2023

Due to some virtual environment problems, i must use sed in Dockerfile for now.

  • Conda
  • venv
RUN curl -O https://raw.githubusercontent.com/AUTOMATIC1111/stable-diffusion-webui/master/webui.sh \
    && sed -i '/source "${venv_dir}"\/bin\/activate/a \ \ \ \ pip install --upgrade pip' webui.sh

@vladmandic
Copy link
Collaborator

vladmandic commented Apr 4, 2023

why would webui.sh launcher update pip and do so without even questioning user if he wants that?

@Manjiz
Copy link
Author

Manjiz commented Apr 6, 2023

why would webui.sh launcher update pip and do so without even questioning user if he wants that?

@vladmandic One goal of webui.sh is to setup the environment. In my case, I met version not found of some requirements without upgrade pip.

Alternatively, enter the venv and upgrade it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants