Upgrade PIP during virtual environment creation

[MarcusNyne]

The default version of PIP with Python 3.10 does not record installation metadata properly for requirements installed using an url, resulting in invalid lines when PIP FREEZE is called. For example, the packages clip and cstr are problematic. This makes it difficult to recreate a stable diffusion virtual environment. Upgrading PIP during virtual environment creation remedies this problem. I have found this is corrected in v24 of PIP.

Description

• Upgrade PIP during virtual environment creation so that PIP FREEZE will report accurate information
• Added PIP --upgrade command in batch file
• To reproduce this issue, review installation of clip and cstr, which report incorrect information in PIP FREEZE

Screenshots/videos:

• Before fix:
  clip==1.0
  cstr==0.1.0
• After fix:
  clip @ https://github.com/openai/CLIP/archive/d50d76daa670286dd6cacf3bcd80b5e4823fc8e1.zip#sha256=b5842c25da441d6c581b53a5c60e0c2127ebafe0f746f8e15561a006c6c3be6a
  cstr @ git+https://github.com/WASasquatch/cstr@0520c29a18a7a869a6e5983861d6f7a4c86f8e9b

Checklist:

• [x ] I have read contributing wiki page
• [x ] I have performed a self-review of my own code
• [x ] My code follows the style guidelines
• [x ] My code passes tests

[w-e-w]

I personally don't have an issue (I think) but some people won't like it

• Pip upgrade before launch #9358 (comment)

[strawberrymelonpanda]

Since it's only in a VENV I'd be ok with it, as the VENV's PIP "belongs" to the project, but behavior should be consistent between Linux/Mac/Windows IMO. (.bat, and .sh)

This seems to only affect Windows's .bat.

[MarcusNyne]

Thanks for taking the time to review, @strawberrymelonpanda .. let me look at it .. I don't currently have a linux/mac installation. I'll see if I can find someone to assist.

[missionfloyd]

This will update pip every time it's started, not just when the venv is created.

[MarcusNyne]

This will update pip every time it's started, not just when the venv is created.

@missionfloyd, that is a good catch! I'll correct the code and resubmit. Thanks for taking the time to review.

[missionfloyd]

You don't need to make a new PR. You can just push additional commits to this branch.

[MarcusNyne]

You don't need to make a new PR. You can just push additional commits to this branch.

@missionfloyd Oops sorry I already created the other PR to keep things clean.
#15750