Style inline code like code blocks (via #1012) #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
added
area: message rendering
PR ready to be merged
This ensures similar rendering of the two code formats, by using the style used for plain codeblocks for inline code: "pygments:w". Test amended. Adapted from the last commit of zulip#1012 by neiljp.
msg_code is no longer used in message rendering, only in an error notification, so it is clearer to rename it to ui_code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adapts the last commit of #1012, which was neglected while discussing how to handle the padding/blocking of codeblock rendering.
The change is now in messages.py, but works well after a manual movement.
The associated removal of
msg_codeis split into a second commit which instead renames the style toui_code, since it is still used in a notification popup. This could have been migrated to use the pygments style too, but for now it feels cleaner to keep pygments within the message rendering functionality, and not hard-code the style elsewhere.Tested?