Skip to content

[WIP] Collapse large messages and scroll through them #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mounilKshah
Copy link
Collaborator

What does this PR do?
This PR contains code to scroll a large message without changing the focus.
Addresses #1168

#zulip-terminal>Condense large messages #T1094

Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

Notes & Questions

  • This commit is still a work in progress.

Interactions

Visual changes

This commit is the first step towards resolving zulip#1168.
MessageView.keypress() has been modified to be able to
scroll up and down a large message which doesn't completely
fit the screen size.
@zulipbot zulipbot added the size: M [Automatic label added by zulipbot] label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants