Isolate typing testing dependencies and upgrade to mypy 0.910 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
force-pushed
the
2021-08-25-mypy-0.910
branch
from
0cdbc17 to
3a600e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is essentially an upgrade to mypy 0.910.
However, from ~0.901, type annotations for libraries not in the standard library are expected to be pulled in externally. For this reason a separate extra is added to
setup.pyfor use by CI when running mypy (first commit) and to group the dependencies together in the second commit when mypy is upgraded.NOTE: I've provisionally used a
[dev]in the commit area to indicate this is a dev-only change, which we can discuss.Tested?