Update index's topic_msg_ids accurately with topic updates.
#1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prah23 This change looks reasonable, though I'll read the tests again before merging, but as per |
prah23
force-pushed
the
topic_msg_ids_bugfix
branch
from
7df3e14 to
827a429
Compare
zulipbot
added
size: L
prah23
force-pushed
the
topic_msg_ids_bugfix
branch
from
827a429 to
d3e242b
Compare
This commit includes more fields under the UpdateMessageEvent class to ensure type-consistent handling for said fields in the update message events conveying topic updates.
Prior to this commit, if a message's topic was changed, the corresponding `message_id` was not removed from the old topic's set under the "topic_msg_ids" key of the model's index. This commit removes the updated `message_id` from that set, ensuring the accuracy of the set. Tests updated.
Prior to this commit, if a message's topic was changed, the corresponding `message_id` was not added to the new topic's set under the "topic_msg_ids" key of the model's index. This commit adds the updated `message_id` to that set, ensuring the accuracy of the new topic's set. Tests updated.
neiljp
force-pushed
the
topic_msg_ids_bugfix
branch
from
d3e242b to
6749809
Compare
|
@prah23 Thanks for the update! 🎉 I tacked a refactor on the end and added a comment to a test, and used a more detailed commit from another PR for the first commit since we can use it later and it was otherwise very tiny :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prior to this PR, if a message's topic was changed, the
corresponding
message_idwas not removed from the old topic's setand added to the new one under the "topic_msg_ids" key of the model's
index. This PR updates the relevant sets to ensure accuracy.
Tested?
Commit flow
api_types: Include the orig_subject field in UpdateMessageEvent.
This commit introduces another field to the UpdateMessageEvent class
in
api_types.pyto accommodate this field in the event handlermethod for update message events.
bugfix: model: Remove updated message_ids from their old topic's set.
Prior to this commit, if a message's topic was changed, the
corresponding
message_idwas not removed from the old topic's setunder the "topic_msg_ids" key of the model's index. This commit removes
the updated
message_idfrom that set, ensuring the accuracy of theset.
Tests updated.