Indent to distinguish resolved topics. #1124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
reviewed
Aug 20, 2021
There was a problem hiding this comment.
@Rohitth007 This looks good, though it would be simpler with a separate API-specific addition for the resolved prefix.
My only other concern is that a long list of unresolved topics looks significantly indented - maybe more so with the text flowing closer to the right hand side.
neiljp
added
area: UI
Rohitth007
force-pushed
the
topic-align
branch
from
ba845bb to
96674eb
Compare
This commit indents all TopicButtons to make space for the resolved topic symbol and easily distinguish between them. A RESOLVED_TOPIC symbol has been added to api_types to be used for recognizing a resolved topic. To make topic name length the same as before, LEFT_WIDTH is increased by 2. This is equivalent to no difference in topic name length and 2 char gain in stream/special narrow buttons. Tests updated.
Rohitth007
force-pushed
the
topic-align
branch
from
96674eb to
68ded84
Compare
zulipbot
added
size: M
preetmishra
reviewed
Aug 21, 2021
| (1, 14, "topic2", "GSoC"), | ||
| (1000, 205, "topic3", "PTEST"), | ||
| (2, 86, "topic1", "Django", False), | ||
| (1, 14, "✔ topic2", "GSoC", True), |
There was a problem hiding this comment.
Since we have a constant defined for the Unicode, let's use it here as well.
|
@Rohitth007 Thanks for extracting this - this looks cleaner! 🎉 I've merged this manually and made a quick follow-up refactor to adjust the constant to match the server, which includes the space and |
neiljp
added
missing feature: user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR indents all TopicButtons to make space for the resolved
topic symbol and easily distinguish between them.
To make topic name length the same as before, the default suffix is
made from 2 spaces to 1 space and the LEFT_WIDTH is increased by 1.
This is equivalent to no difference in topic name length and 2 char
gain in stream/special narrow buttons.
Tested?
Visual changes
