refactor: tests: buttons: Add type annotations. #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prah23
force-pushed
the
test_annotation_buttons
branch
from
5b5a1ec to
7426970
Compare
neiljp
reviewed
Jul 29, 2021
| expected_prefix: List[str], | ||
| text_color: Optional[str], | ||
| count_text: Tuple[Optional[str], str], | ||
| expected_suffix: List[Any], |
There was a problem hiding this comment.
Improving this is pending on the urwid markup PR, or something like it.
neiljp
added
the
PR awaiting update
prah23
force-pushed
the
test_annotation_buttons
branch
from
7426970 to
3bb184c
Compare
|
Thanks for taking a look, @neiljp! I've accommodated the changes suggested, only the second point on the review is left, which is pending on other urwid-markup typing refactor work (I've also updated the PR description accordingly). |
prah23
removed
the
PR awaiting update
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
prah23
force-pushed
the
test_annotation_buttons
branch
2 times, most recently
from
90a79b2 to
aaac0d4
Compare
This commit refactors certain test parameters that are of the `ParsedNarrowLink` type to `ParsedNarrowLink` instances and parameters of the type `DecodedStream` to `DecodeStream` instances from the current dict instances to ensure type consistency.
This commit assigns fixture method attribute `mocker.patch`s to variables, so that the corresponding asserts can be called on the mocked nature, as was the original intention.
This commit adds parameter and return type annotations or hints to the `test_buttons.py` file, that contains tests for it's counterpart `buttons.py` from the `zulipterminal` module, to make mypy checks consistent and improve code readability.
This commit adds `test_buttons.py` to the `type_consistent_testfiles` list to check for type consistency with mypy.
neiljp
force-pushed
the
test_annotation_buttons
branch
from
aaac0d4 to
28d3ade
Compare
|
@prah23 Thanks for this and the updates 👍 Merging with slight commit message tweaks shortly! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds type annotations to test_buttons.py and adds the file to the list in run-mypy. Also has a prior refactor commit to assign
mocker.patchs to variables.Tested?
Commit flow
refactor: tests: buttons: Assign method mocker.patchs to variables.
This commit assigns fixture method attribute
mocker.patchs tovariables, so that the corresponding asserts can be called on the
mocked nature, as was the original intention.
refactor: tests: buttons: Add type annotations.
This commit adds parameter and return type annotations or hints to the
test_buttons.pyfile, that contains tests for it's counterpartbuttons.pyfrom thezulipterminalmodule, to make mypy checksconsistent and improve code readability.
tools: Include test_buttons.py to be checked by mypy.
This commit adds
test_buttons.pyto thetype_consistent_testfileslist to check for type consistency with mypy.
Waiting on:
Refactor work to improve type annotations for urwid markup.