Apply black to tools/ and setup.py #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: tools/lister.py was imported from zulip/zulip as a helper for tools/run-mypy and has not been edited directly significantly subsequently. As such, no specific allowances are made in applying black to lister.py, since black preserves functionality and in future we expect to move to the lister functionality present in zulint.
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With tools/ and setup.py included in black linting, all python files will then be checked by black 🎉
These were originally excluded for simplicity, but to remove certain linting rules it is useful to ensure black is applied to all python files, such as for line length ie. removing flake8 rule E501 in #1084
This is a partial fix towards #1047
Tested?
Commit flow
As per the original main black transition:
Interactions
I'd like to merge this before #1084, since that PR currently loosens our flake8 rules based on the premise that black is being applied.