tests: run: Add type annotations. #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This commit adds paramter and return type annotations or hints to the `test_run.py` file, that contains tests for it's counterpart `run.py` from the `zulipterminal` module, to make mypy checks consistent and improve code readability. Small type fixups and explicit CaptureFixture import added by neiljp.
This commit adds a new "tests" key to the `repo_python_files` dict to let mypy know which files to type check. A new list, `type_consistent_testfiles` is also added, to hold the list of test files that have been type-annotated incrementally till all the test files are consistent.
neiljp
force-pushed
the
test_annotation_run
branch
from
eb70237 to
fccc589
Compare
|
@prah23 Merging now! 🎉 |
|
Thanks for the feedback and the merge @neiljp! |
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds type annotations to the
test_run.pyfile. Includes this file under therun-mypytool to type-check.Tested?
Commit flow
This commit adds paramter and return type annotations or hints to the
test_run.pyfile, that contains tests for it's counterpartrun.pyfrom the
zulipterminalmodule, to make mypy checks consistent andimprove code readability.
This commit adds a new "tests" key to the
repo_python_filesdict tolet mypy know which files to type check. A new list,
type_consistent_testfilesis also added, to hold the list of testfiles that have been type-annotated incrementally till all the test
files are consistent.
Notes & Questions
I've referred to the
pytestandpytest-mockdocs for the type annotations on some of the fixtures, is a reference link in the commit necessary? (one reference would then be to a CHANGELOG)