-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce application-wide time format setting #770
Comments
Note that if we can use the API to fetch user settings then we could use that as a reasonable default. |
Hey , @neiljp . I looked into the Zulip Api documentation (https://zulip.com/api/get-user) , but I don't see a response type which signifies the user's time-format setting ( Maybe its stored in client side ). Is there something I am missing out ? |
@aryanshridhar I believe this is not currently documented in the server. Based on reading |
Initial time format settings are fetched during initial register call. Event handler enables update of this setting as events arerecieved from the server. Fixes zulip#770
Initial time format settings are fetched during initial register call. Event handler enables update of this setting as events are recieved from the server. Fixes zulip#770
Initial time format settings are fetched during initial register call. Event handler enables update of this setting as events are recieved from the server. Tests added. Fixes zulip#770
Initial time format settings are fetched during initial register call. Event handler enables update of this setting as events are recieved from the server. Tests added. Fixes zulip#770
Currently, we default to the 24-hour time format in Zulip Terminal. It would be reasonable to introduce an application-wide setting to select between the 12-hour and the 24-hour time format.
For v1, we might want to introduce it as a custom
zuliprc
setting. (In the web app, it is shown underSettings > Display settings
.)Lastly, we would want to discuss which time format should be the new default.
The text was updated successfully, but these errors were encountered: