Skip to content

Migrate away from supporting theme aliases? #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neiljp opened this issue May 5, 2020 · 2 comments
Open

Migrate away from supporting theme aliases? #648

neiljp opened this issue May 5, 2020 · 2 comments

Comments

@neiljp
Copy link
Collaborator

neiljp commented May 5, 2020

In #612 we migrate theme names and add an alias table which allows the old names to continue working.

This issue is to track whether in future we remove this theme aliases dict - possibly in one major release first as a fatal error at loading, indicating more strongly that the theme should be replaced (or automatically updated in the file, or other location?) - and then in the next significant release actually removing the aliases and treating the old names as invalid.

@neiljp neiljp added the FUTURE label May 5, 2020
neiljp added a commit to neiljp/zulip-terminal that referenced this issue May 5, 2020
A message is output on loading indicating if the theme loading is an
alias of another theme.

Theme aliases may be removed in future (zulip#648).

Tests updated.
neiljp added a commit that referenced this issue May 5, 2020
A message is output on loading indicating if the theme loading is an
alias of another theme.

Theme aliases may be removed in future (#648).

Tests updated.
@Ezio-Sarthak
Copy link
Member

Could you elaborate about automatically updating, and potentially in which file?

@neiljp
Copy link
Collaborator Author

neiljp commented Apr 5, 2021

Automatically updating would be the source of the provided configuration; I'm wary of doing this as we're touching user config, but we're not yet at a stage where we need to consider this change. This may be less problematic after #678 if the config is separated from profiles and we generate a guaranteed new proposed config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants