Two users with the the same name appear as the same person #1151
Comments
|
@lzmartinico Thanks for reporting this! I suspect this is present in This should be fairly simple to resolve via comparing user ids rather than names. |
|
Glad to hear there is an easy fix! Maybe there should be another ticket (or meta ticket), but support for users with the same name is somewhat lacking overall (e.g. when tagging a user through autocompletion, it's impossible to know which one is selected) |
|
@lzmartinico Autocomplete is improved further in the current development version after GSoC, and may well resolve the issue you're describing. Generally if you have other separate then other issues (or a general issue we can split out) are a good idea - or if you wish to discuss a potential range of issues then it's likely better to raise this in a topic in the #zulip-terminal stream on chat.zulip.org :) |
|
@lzmartinico thank you for the feedback! We have additional autocomplete improvements for tagging users (disambiguation using an appended user ID, #928 for reference), as well as using users' names as private message recipients, currently on the Any additional feedback is highly appreciated! |
|
Hi all, |
|
Hello @Dishti-Oberai! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
|
@Dishti-Oberai You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
|
I am still working on it |
|
Hi is this still an issue? How would you solve the problem of the names being same? Displaying the ids with the names in the sender name instead of just the name? |
|
@Sushmey Thanks for your interest in the project! To clarify based on your doing a capture of the zulip web app, this issue tracker is for zulip-terminal, not the zulip web app. If there is an issue there, then it needs resolving separately, though from the screenshot it seems that if the user profile picture is different then that is one way to show it (or cause the problem). Manually one can also look at the senders, but that's not preferred I expect. For zulip-terminal, perhaps obviously, we don't have user profiles to distinguish, which I expect is why you suggested the ids? The other current issue here is that the same 'A0' header (in your case) will be used in ZT for both messages, so it really looks like the messages are from the same user - the sender header is not even repeated. That was the change I was planning to address first. Once we have that, then we'll also be able to distinguish adjacent messages, so could consider adjusting the sender somehow. That'd need to be carefully done, to avoid indicating that the sender name was actually different. |
|
Oh thank you for pointing that out! I was under the impression that the web app was the one where the problem could be recreated but it's only where you discuss the problems. I see that someone in that someone has already solved it? Please let me know so I can try my hand at it |
|
@zulipbot claim |
|
Welcome to Zulip, @Sushmey! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
Updating boxes.py to pass lint check Fixes zulip#1151 Update boxes.py made users_list global by adding global keyword Update boxes.py user names now show id even when not adjacent Update boxes.py globally defined user_names_counter so it needs to be calculated only once Update boxes.py cleaning up the code a bit Update boxes.py black reformatting made function in model.py to get username count created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name black reformatting black lint isort isort import order reformatting using .get() instead of the key and removing commented out code squashing commits
Updating boxes.py to pass lint check Fixes zulip#1151 Update boxes.py made users_list global by adding global keyword Update boxes.py user names now show id even when not adjacent Update boxes.py globally defined user_names_counter so it needs to be calculated only once Update boxes.py cleaning up the code a bit Update boxes.py black reformatting made function in model.py to get username count created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name black reformatting black lint isort isort import order reformatting using .get() instead of the key and removing commented out code squashing commits reformatting using .get() instead of the key and removing commented out code
Updating boxes.py to pass lint check Fixes zulip#1151 Update boxes.py made users_list global by adding global keyword Update boxes.py user names now show id even when not adjacent Update boxes.py globally defined user_names_counter so it needs to be calculated only once Update boxes.py cleaning up the code a bit Update boxes.py black reformatting made function in model.py to get username count created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name black reformatting black lint isort isort import order reformatting using .get() instead of the key and removing commented out code squashing commits reformatting using .get() instead of the key and removing commented out code
Updating boxes.py to pass lint check Fixes zulip#1151 Update boxes.py made users_list global by adding global keyword Update boxes.py user names now show id even when not adjacent Update boxes.py globally defined user_names_counter so it needs to be calculated only once Update boxes.py cleaning up the code a bit Update boxes.py black reformatting made function in model.py to get username count created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name black reformatting black lint isort isort import order squashing all commits in one
Updating boxes.py to pass lint check Fixes zulip#1151 Update boxes.py made users_list global by adding global keyword Update boxes.py user names now show id even when not adjacent Update boxes.py globally defined user_names_counter so it needs to be calculated only once Update boxes.py cleaning up the code a bit Update boxes.py black reformatting made function in model.py to get username count created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name black reformatting black lint isort isort import order squashing all commits in one Updating boxes.py to pass lint check Fixes zulip#1151 Update boxes.py made users_list global by adding global keyword Update boxes.py user names now show id even when not adjacent Update boxes.py globally defined user_names_counter so it needs to be calculated only once Update boxes.py cleaning up the code a bit made function in model.py to get username count created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name isort isort import order Update boxes.py Updating boxes.py to pass lint check Fixes zulip#1151 Update boxes.py made users_list global by adding global keyword Update boxes.py user names now show id even when not adjacent Update boxes.py globally defined user_names_counter so it needs to be calculated only once Update boxes.py cleaning up the code a bit Update boxes.py black reformatting made function in model.py to get username count created a class variable in model class so that username count dict is calculated only once and using it to get number of users with same name and display id beside their name black reformatting black lint isort isort import order reformatting using .get() instead of the key and removing commented out code squashing commits reformatting using .get() instead of the key and removing commented out code
|
Hi @SRV332003 |
Users with same name had their adjacent messages displayed under the same header and no visually discerning feature was available for users with same name. This solves that. Fixes zulip#1151.
Users with same name had their adjacent messages displayed under the same header and no visually discerning feature was available for users with same name. This solves that. Fixes zulip#1151.
Users with same name had their adjacent messages displayed under the same header and no visually discerning feature was available for users with same name. This solves that. Fixes zulip#1151.
|
@Sushmey You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
Users with same name had their adjacent messages displayed under the same header and no visually discerning feature was available for users with same name. This solves that. Fixes zulip#1151.
|
@Sushmey You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
|
Welcome to Zulip, @Chan-Dong-Jun! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
Users with same name had their adjacent messages displayed under the same header and no visually discerning feature was available for users with same name. This solves that. Fixes zulip#1151.
Users with same name had their adjacent messages displayed under the same header and no visually discerning feature was available for users with same name. This solves that. Fixes zulip#1151.
|
@Sushmey You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
|
@zulipbot claim |
|
Hello @vats004, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again. We look forward to your valuable contributions! |
|
The code changes published for the above PR seem to be working locally. Issue: different users with same name seem appear as a single user on zulip terminal. Fix: display author_id along with author name to distinguish between users. Image one shows zulip terminal with the latest code of commits by 13th February 2024. Image two shows zulip terminal without the latest code of commits by 13th February 2024:
|
On zulip-term version 0.6.0, if two users have the same name and send two messages in sequence within the same topic, the messages will be displayed as if coming from the same user
The text was updated successfully, but these errors were encountered: