Skip to content

Apply latest meta/config templates #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

dataflake
Copy link
Member

No description provided.

@dataflake dataflake requested review from tseaver and icemac August 26, 2024 13:35
Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the equivalent persistent PR, I don't have a particular issue with the changes, but feel that applying new linting should not be done while there are unmerged "substantive" PRs (e.g, #208, #209).

@dataflake
Copy link
Member Author

As with the equivalent persistent PR, I don't have a particular issue with the changes, but feel that applying new linting should not be done while there are unmerged "substantive" PRs (e.g, #208, #209).

If your concern is merging issues then I don't see the problem - the linting only affects Python files, which your PRs don't touch at all with one small exception.

@dataflake dataflake merged commit c755219 into master Aug 27, 2024
51 checks passed
@dataflake dataflake deleted the config-with-c-code-template-9e2b2911 branch August 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants