Log how many rows were written for staging query

[david-zlai]

Summary

^^^

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• New Features

  • Added logging to display the number of rows written after saving data in batch processing.

• Bug Fixes

  • Improved compatibility for command-line options by ensuring default values are correctly formatted as strings.

[coderabbitai]

Walkthrough

The changes update the default value for a command-line option in a Python CLI to ensure type consistency and add a logging statement in a Scala batch process to report the number of rows written after each save operation.

Changes

File(s)	Summary
api/python/ai/chronon/repo/run.py	Changed the default for the --mode CLI option from an enum to its string representation.
spark/src/main/scala/ai/chronon/spark/batch/StagingQuery.scala	Added a log statement to report the number of rows written after saving each DataFrame.

Possibly related PRs

• Fix modes allowed in CLI #764: Also modifies the --mode option in the same Python CLI to ensure string types are used for choices and default value.

Suggested reviewers

• tchow-zlai

Poem

Code now logs with cheerful might,
Rows written tallied, a data delight.
CLI modes stringed up just right,
Type errors banished out of sight.
In every change, a future bright!
✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76f83d5 and bc2eae2.

📒 Files selected for processing (2)

• api/python/ai/chronon/repo/run.py (1 hunks)
• spark/src/main/scala/ai/chronon/spark/batch/StagingQuery.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (32)

• GitHub Check: cloud_aws_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: service_tests
• GitHub Check: streaming_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: join_tests
• GitHub Check: service_commons_tests
• GitHub Check: spark_tests
• GitHub Check: api_tests
• GitHub Check: streaming_tests
• GitHub Check: online_tests
• GitHub Check: join_tests
• GitHub Check: service_tests
• GitHub Check: groupby_tests
• GitHub Check: flink_tests
• GitHub Check: groupby_tests
• GitHub Check: online_tests
• GitHub Check: analyzer_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: batch_tests
• GitHub Check: flink_tests
• GitHub Check: spark_tests
• GitHub Check: api_tests
• GitHub Check: fetcher_tests
• GitHub Check: aggregator_tests
• GitHub Check: fetcher_tests
• GitHub Check: aggregator_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: analyzer_tests
• GitHub Check: python_tests
• GitHub Check: batch_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (2)

api/python/ai/chronon/repo/run.py (1)

109-109: Type consistency fix looks good

This change properly converts the enum to string for click.Choice compatibility.

spark/src/main/scala/ai/chronon/spark/batch/StagingQuery.scala (1)

73-75:

✅ Verification successful

Added row count logging as requested

The implementation logs the number of rows written after each save operation, fulfilling the PR objective.

---

🏁 Script executed:

#!/bin/bash
# Check for similar logging patterns elsewhere in the codebase
rg "rows" --type scala | grep -i "wrote" 

Length of output: 150

---

Approve row count logging

• Added in spark/src/main/scala/ai/chronon/spark/batch/StagingQuery.scala
• No other “Wrote … rows” occurrences found

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[piyush-zlai]

could fold this log line into the above no?