Skip to content

feat: broadcast aggregators only once per executor #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tchow-zlai
Copy link
Collaborator

@tchow-zlai tchow-zlai commented May 17, 2025

Summary

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Performance Improvements

    • Enhanced processing efficiency by broadcasting key aggregator components during group-by operations.
  • Chores

    • Added new class registrations to improve serialization during data processing.

Copy link

coderabbitai bot commented May 17, 2025

Walkthrough

The update broadens broadcasting of SawtoothAggregator, SawtoothMutationAggregator, and HopsAggregator instances across multiple GroupBy methods, replacing local aggregators with broadcast variables. It also adds explicit Kryo registrations for these aggregator classes using JavaSerializer in ChrononKryoRegistrator. No signature or behavior changes occur.

Changes

File(s) Change Summary
spark/src/main/scala/ai/chronon/spark/GroupBy.scala Broadcasts SawtoothAggregator, SawtoothMutationAggregator, and HopsAggregator in snapshotEventsBase, temporalEntities, temporalEvents, and hopsAggregate.
spark/src/main/scala/ai/chronon/spark/submission/ChrononKryoRegistrator.scala Registers SawtoothAggregator, SawtoothMutationAggregator, and HopsAggregator with Kryo using JavaSerializer in doRegister.

Suggested reviewers

  • varant-zlai
  • piyush-zlai

Poem

📡 Broadcasts soar through Spark’s domain,
Aggregators shared, no work in vain.
Kryo knows them, now registered right,
Serialization’s shining light.
Code refined with care and grace,
Distributed wins the race! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4bf9abd and 56399a7.

📒 Files selected for processing (2)
  • spark/src/main/scala/ai/chronon/spark/GroupBy.scala (6 hunks)
  • spark/src/main/scala/ai/chronon/spark/submission/ChrononKryoRegistrator.scala (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • spark/src/main/scala/ai/chronon/spark/submission/ChrononKryoRegistrator.scala
  • spark/src/main/scala/ai/chronon/spark/GroupBy.scala
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: streaming_tests
  • GitHub Check: join_tests
  • GitHub Check: groupby_tests
  • GitHub Check: analyzer_tests
  • GitHub Check: batch_tests
  • GitHub Check: spark_tests
  • GitHub Check: fetcher_tests
  • GitHub Check: enforce_triggered_workflows

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tchow-zlai tchow-zlai force-pushed the tchow/broadcast-stuff branch from edfec4c to cac455d Compare May 17, 2025 22:25
@tchow-zlai tchow-zlai force-pushed the tchow/broadcast-stuff branch from 93bb09b to 8548a63 Compare May 17, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants