Fixing partition spec column setting in table deps

[varant-zlai]

Summary

Setting the partition spec correctly in table dependencies

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Bug Fixes
  • Corrected the partition column used for snapshot table dependencies to ensure accurate data partitioning.

[coderabbitai]

Walkthrough

The change updates the partition column used in the TableInfo object within the TableDependencies.fromJoin method. For non-temporal joins, it replaces the hardcoded "dt" partition column with the value from the provided PartitionSpec, making the partition column assignment dynamic.

Changes

File(s)	Change Summary
api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala	Replaces hardcoded "dt" partition column with dynamic spec.column from PartitionSpec in fromJoin method for non-temporal joins.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant TableDependencies
    participant PartitionSpec

    Caller->>TableDependencies: fromJoin(join, spec)
    TableDependencies->>PartitionSpec: Get partition column (spec.column)
    TableDependencies-->>Caller: TableDependency with partition column = spec.column

Loading

Possibly related PRs

• Using tableUtils.partitionColumn rather than hardcoded ds #579: Also replaces hardcoded partition column strings with dynamic references, enhancing partition column flexibility.
• replace partition spec with column #776: Refactors partition specification usage, aligning with the update to use PartitionSpec for partition columns.

Suggested reviewers

• nikhil-zlai

Poem

In the land where columns dwell,
"dt" once ruled partition’s shell.
Now spec.column takes the throne,
Dynamic, flexible, fully grown.
Code evolves and so do we—
Cheers to change and clarity! 🎉

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 7413cde and a35315e.

📒 Files selected for processing (1)

• api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: flink_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: service_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: service_tests
• GitHub Check: service_commons_tests
• GitHub Check: online_tests
• GitHub Check: cloud_gcp_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: api_tests
• GitHub Check: online_tests
• GitHub Check: aggregator_tests
• GitHub Check: api_tests
• GitHub Check: flink_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: aggregator_tests

🔇 Additional comments (1)

api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala (1)

63-63: Fix looks good - Dynamic partition column.

Correctly uses spec.column instead of hardcoded value for partition column in non-temporal joins.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.