Skip to content

Add label join flag to custom json for airflow #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

varant-zlai
Copy link
Collaborator

@varant-zlai varant-zlai commented May 15, 2025

Summary

Adding a flag so that airflow integration knows whether to schedule a join or not

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • New Features
    • Enhanced join metadata to include a flag indicating the presence of label parts.
  • Tests
    • Updated sample join test to include label part information in join instantiation.

Copy link

coderabbitai bot commented May 15, 2025

Walkthrough

A new helper function _set_label_join_flag(join) is added to update the customJson metadata of a join object with a "label_join" boolean flag based on the presence of labelParts. This function is integrated into the join dependency setup. Additionally, a test sample now includes a label_part in the Join instantiation.

Changes

File(s) Change Summary
api/python/ai/chronon/airflow_helpers.py Added _set_label_join_flag(join) to set "label_join" in customJson. Updated _set_join_deps(join) to call this helper.
api/python/test/sample/joins/sample_team/sample_join.py Added LabelParts import and included label_part argument in Join instantiation.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Join
    participant AirflowHelpers

    Caller->>AirflowHelpers: _set_join_deps(join)
    AirflowHelpers->>Join: Set Airflow dependencies
    AirflowHelpers->>AirflowHelpers: _set_label_join_flag(join)
    AirflowHelpers->>Join: Update customJson with label_join flag
Loading

Suggested reviewers

  • david-zlai

Poem

In the land of joins and flags anew,
A label checks if parts are true.
With customJson, the truth is shown,
Airflow helpers set the tone.
A sample test with parts in line—
Code and metadata intertwine!
🚦✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 30f5356 and 2ab9bca.

📒 Files selected for processing (2)
  • api/python/ai/chronon/airflow_helpers.py (2 hunks)
  • api/python/test/sample/joins/sample_team/sample_join.py (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
api/python/test/sample/joins/sample_team/sample_join.py (1)
api/python/ai/chronon/join.py (1)
  • LabelParts (252-287)
⏰ Context from checks skipped due to timeout of 90000ms (16)
  • GitHub Check: service_tests
  • GitHub Check: cloud_gcp_tests
  • GitHub Check: service_commons_tests
  • GitHub Check: cloud_aws_tests
  • GitHub Check: cloud_gcp_tests
  • GitHub Check: service_tests
  • GitHub Check: cloud_aws_tests
  • GitHub Check: api_tests
  • GitHub Check: online_tests
  • GitHub Check: api_tests
  • GitHub Check: online_tests
  • GitHub Check: flink_tests
  • GitHub Check: aggregator_tests
  • GitHub Check: aggregator_tests
  • GitHub Check: flink_tests
  • GitHub Check: python_tests
🔇 Additional comments (4)
api/python/test/sample/joins/sample_team/sample_join.py (2)

23-23: Added LabelParts import.

Import needed for usage on line 36.


36-36: Added label_part parameter.

Correctly implementing the new label join functionality with appropriate parameters.

api/python/ai/chronon/airflow_helpers.py (2)

152-153: Added label join flag setting.

Properly integrates the new function at the appropriate location after dependencies are set.


176-184: Implemented label join flag setting.

Function correctly:

  1. Handles existing or empty JSON
  2. Sets flag based on labelParts presence
  3. Updates metadata

Meets PR objective of creating a flag for Airflow to determine whether to schedule a join operation.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tchow-zlai tchow-zlai merged commit c44643e into main May 15, 2025
20 checks passed
@tchow-zlai tchow-zlai deleted the vz/add_label_join_flag_to_custom_json_for_airflow branch May 15, 2025 19:30
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

Adding a flag so that airflow integration knows whether to schedule a
join or not

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced join metadata to include a flag indicating the presence of
label parts.
- **Tests**
- Updated sample join test to include label part information in join
instantiation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: ezvz <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

Adding a flag so that airflow integration knows whether to schedule a
join or not

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced join metadata to include a flag indicating the presence of
label parts.
- **Tests**
- Updated sample join test to include label part information in join
instantiation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: ezvz <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary

Adding a flag so that airflow integration knows whether to schedule a
join or not

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced join metadata to include a flag indicating the presence of
label parts.
- **Tests**
- Updated sample join test to include label part information in join
instantiation.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: ezvz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants