fix: remove some nondeterministic timestamp in ChainingFetcherTest

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Simplified test logic for handling partition dates, making tests rely on the expected data's partition date.
  • Cleaned up and reordered import statements for improved clarity.
• Tests
  • Updated test method signatures and calls to streamline date handling in test comparisons.

[coderabbitai]

Walkthrough

This update refactors the ChainingFetcherTest by cleaning up import statements, removing redundant variables, and simplifying the handling of partition dates in test comparisons. The compareTemporalFetch method signature is updated to remove the endDs parameter, and related logic is streamlined accordingly.

Changes

File(s)	Change Summary
spark/src/test/scala/ai/chronon/spark/test/fetcher/ChainingFetcherTest.scala	Reordered and cleaned imports; removed unused variables; simplified date handling; updated compareTemporalFetch signature and its usages.

Suggested reviewers

• varant-zlai
• david-zlai
• piyush-zlai

Poem

In tests where dates once danced around,
Now clarity and order are found.
Imports aligned, old vars retired,
The code is leaner, as required.
With each refactor, bugs take flight—
Simpler tests, more restful night!
✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f08593b and 0526267.

📒 Files selected for processing (1)

• spark/src/test/scala/ai/chronon/spark/test/fetcher/ChainingFetcherTest.scala (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (6)

spark/src/test/scala/ai/chronon/spark/test/fetcher/ChainingFetcherTest.scala (6)

19-37: Import statements cleaned up.

Imports are now better organized and redundancies removed.

---

48-48: Simplified SparkSessionBuilder reference.

Direct import allows cleaner instantiation.

---

264-264: Replaced variable with parameter.

Using endDs directly improves code clarity.

---

276-280: Simplified method signature.

Removed endDs parameter that's no longer needed.

---

314-314: Updated method call.

Call signature matches new definition.

---

323-323: Updated method call.

Call signature matches new definition.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.