chore: drop tables in the join integration test #735
Conversation
WalkthroughThe cleanup phase of the Changes
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
scripts/distribution/run_gcp_quickstart.sh(1 hunks)
🔇 Additional comments (1)
scripts/distribution/run_gcp_quickstart.sh (1)
74-74: Verify BigQuery table name syntax
Confirm thatdata.gcp_training_set.v1_testis a valid table identifier. BigQuery table IDs typically can’t contain dots—this may need to begcp_training_set_v1_testor usedata.gcp_training_setas the dataset andv1_testas the table.
| else | ||
| bq rm -f -t canary-443022:data.gcp_purchases_v1_dev | ||
| bq rm -f -t canary-443022:data.gcp_purchases_v1_view_dev | ||
| bq rm -f -t canary-443022:data.gcp_purchases_v1_dev_upload | ||
| bq rm -f -t canary-443022:data.gcp_training_set.v1_dev |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Parameterize project ID for both environments
You’re hard-coding canary-443022 even in the dev branch, which risks deleting the wrong tables. Introduce a PROJECT_ID (e.g. based on $ENVIRONMENT) and reference it here to DRY up and safeguard these calls.
## Summary
- Drop tables in the join integration tests.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Enhanced cleanup process to remove additional BigQuery tables in
"canary" and "dev" environments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: thomaschow <[email protected]>
## Summary
- Drop tables in the join integration tests.
## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Enhanced cleanup process to remove additional BigQuery tables in
"canary" and "dev" environments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: thomaschow <[email protected]>
## Summary
- Drop tables in the join integration tests.
## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Enhanced cleanup process to remove additional BigQuery tables in
"canary" and "dev" environments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
---------
Co-authored-by: thomaschow <[email protected]>
Summary
Checklist
Summary by CodeRabbit