feat: support primary partition listing for bq native tables and views #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Chow <[email protected]>
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant BigQueryNative
participant BigQuery
participant SparkSession
Caller->>BigQueryNative: primaryPartitions(tableName, partitionColumn, subPartitionsFilter)
BigQueryNative->>BigQueryNative: Check if subPartitionsFilter is empty
alt subPartitionsFilter is not empty
BigQueryNative-->>Caller: Throw NotImplementedError
else
BigQueryNative->>BigQuery: Execute SQL for distinct partition values
BigQuery->>SparkSession: Return results
SparkSession-->>BigQueryNative: List of partition values
BigQueryNative-->>Caller: Return List[String]
end
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryNative.scala (2)
81-83: Redundant condition check.Class returns true for supportSubPartitionsFilter (line 178), so check will never trigger.
103-104: Missing null handling.No explicit handling for null values in partition column.
- partVals.as[String].collect().toList + partVals.filter(col(partitionColumn).isNotNull).as[String].collect().toList
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryNative.scala(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (18)
- GitHub Check: cloud_gcp_tests
- GitHub Check: cloud_aws_tests
- GitHub Check: cloud_aws_tests
- GitHub Check: cloud_gcp_tests
- GitHub Check: service_tests
- GitHub Check: service_tests
- GitHub Check: online_tests
- GitHub Check: online_tests
- GitHub Check: hub_tests
- GitHub Check: service_commons_tests
- GitHub Check: flink_tests
- GitHub Check: flink_tests
- GitHub Check: hub_tests
- GitHub Check: api_tests
- GitHub Check: aggregator_tests
- GitHub Check: aggregator_tests
- GitHub Check: scala_compile_fmt_fix
- GitHub Check: api_tests
Comment on lines
+89
to
+103
| val bqPartSQL = | ||
| s""" | ||
| |select distinct ${partitionColumn} FROM ${tableName} | ||
| |""".stripMargin | ||
|
|
||
| val partVals = sparkSession.read | ||
| .format(bqFormat) | ||
| .option("project", providedProject) | ||
| // See: https://github.com/GoogleCloudDataproc/spark-bigquery-connector/issues/434#issuecomment-886156191 | ||
| // and: https://cloud.google.com/bigquery/docs/information-schema-intro#limitations | ||
| .option("viewsEnabled", true) | ||
| .option("materializationDataset", tableIdentifier.getDataset) | ||
| .load(bqPartSQL) | ||
|
|
||
| partVals.as[String].collect().toList |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Unused subPartitionsFilter parameter.
Method checks if filter is supported but doesn't use it in query.
- s"""
- |select distinct ${partitionColumn} FROM ${tableName}
- |""".stripMargin
+ s"""
+ |select distinct ${partitionColumn} FROM ${tableName}
+ |${if (subPartitionsFilter.nonEmpty) s"WHERE " + subPartitionsFilter.map { case (k, v) => s"`$k` = '$v'" }.mkString(" AND ") else ""}
+ |""".stripMargin📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| val bqPartSQL = | |
| s""" | |
| |select distinct ${partitionColumn} FROM ${tableName} | |
| |""".stripMargin | |
| val partVals = sparkSession.read | |
| .format(bqFormat) | |
| .option("project", providedProject) | |
| // See: https://github.com/GoogleCloudDataproc/spark-bigquery-connector/issues/434#issuecomment-886156191 | |
| // and: https://cloud.google.com/bigquery/docs/information-schema-intro#limitations | |
| .option("viewsEnabled", true) | |
| .option("materializationDataset", tableIdentifier.getDataset) | |
| .load(bqPartSQL) | |
| partVals.as[String].collect().toList | |
| val bqPartSQL = | |
| s""" | |
| |select distinct ${partitionColumn} FROM ${tableName} | |
| |${if (subPartitionsFilter.nonEmpty) | |
| s"WHERE " + | |
| subPartitionsFilter | |
| .map { case (k, v) => s"`$k` = '$v'" } | |
| .mkString(" AND ") | |
| else ""} | |
| |""".stripMargin | |
| val partVals = sparkSession.read | |
| .format(bqFormat) | |
| // See: https://github.com/GoogleCloudDataproc/spark-bigquery-connector/issues/434#issuecomment-886156191 | |
| // and: https://cloud.google.com/bigquery/docs/information-schema-intro#limitations | |
| .option("project", providedProject) | |
| .option("viewsEnabled", true) | |
| .option("materializationDataset", tableIdentifier.getDataset) | |
| .load(bqPartSQL) | |
| partVals.as[String].collect().toList |
Comment on lines
+91
to
+92
| |select distinct ${partitionColumn} FROM ${tableName} | ||
| |""".stripMargin |
There was a problem hiding this comment.
SQL injection risk in partitionColumn.
Direct string interpolation in SQL queries is risky.
- |select distinct ${partitionColumn} FROM ${tableName}
+ |select distinct `${partitionColumn}` FROM ${tableName}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| |select distinct ${partitionColumn} FROM ${tableName} | |
| |""".stripMargin | |
| |select distinct `${partitionColumn}` FROM ${tableName} | |
| |""".stripMargin |
Co-authored-by: Thomas Chow <[email protected]>
tchow-zlai
force-pushed
the
tchow/support-part-filters
branch
from
7c42e72 to
97a8588
Compare
Co-authored-by: Thomas Chow <[email protected]>
tchow-zlai
force-pushed
the
tchow/support-part-filters
branch
from
989b4d8 to
b7a83eb
Compare
Co-authored-by: Thomas Chow <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala (3)
59-63: Add comment explaining why this test is ignoredLike line 170, consider adding a comment explaining this test requires a BigQuery connection.
59-63: Enhance test robustnessTest only validates partition count. Consider:
- Verifying specific partition values
- Confirming the tested object is actually a view
62-62: Avoid hardcoded expectationsThe expected count of 30 seems specific to this test data. Consider making this more resilient to data changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/BigQueryCatalogTest.scala (3)
cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryNative.scala (1)
partitions(107-176)spark/src/main/scala/ai/chronon/spark/catalog/TableUtils.scala (1)
partitions(183-205)cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryExternal.scala (1)
partitions(95-97)
⏰ Context from checks skipped due to timeout of 90000ms (19)
- GitHub Check: cloud_aws_tests
- GitHub Check: service_tests
- GitHub Check: cloud_gcp_tests
- GitHub Check: service_commons_tests
- GitHub Check: online_tests
- GitHub Check: cloud_aws_tests
- GitHub Check: hub_tests
- GitHub Check: service_tests
- GitHub Check: online_tests
- GitHub Check: api_tests
- GitHub Check: flink_tests
- GitHub Check: cloud_gcp_tests
- GitHub Check: hub_tests
- GitHub Check: aggregator_tests
- GitHub Check: api_tests
- GitHub Check: flink_tests
- GitHub Check: scala_compile_fmt_fix
- GitHub Check: aggregator_tests
- GitHub Check: enforce_triggered_workflows
piyush-zlai
approved these changes
Apr 30, 2025
nikhil-zlai
approved these changes
Apr 30, 2025
This was referenced Apr 30, 2025
kumar-zlai
pushed a commit
that referenced
this pull request
May 1, 2025
#701) ## Summary - For bigquery views, there won't be an explicit partition column on the table. Let's just use the same implementation to list primary part columns. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved partition handling for BigQuery tables, allowing direct retrieval of distinct partition values. - **Bug Fixes** - Added clear error handling for unsupported sub-partition filtering in BigQuery partition queries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
This was referenced May 1, 2025
Merged
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
#701) ## Summary - For bigquery views, there won't be an explicit partition column on the table. Let's just use the same implementation to list primary part columns. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved partition handling for BigQuery tables, allowing direct retrieval of distinct partition values. - **Bug Fixes** - Added clear error handling for unsupported sub-partition filtering in BigQuery partition queries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
#701) ## Summary - For bigquery views, there won't be an explicit partition column on the table. Let's just use the same implementation to list primary part columns. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved partition handling for BigQuery tables, allowing direct retrieval of distinct partition values. - **Bug Fixes** - Added clear error handling for unsupported sub-partition filtering in BigQuery partition queries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
#701) ## Summary - For bigquery views, there won't be an explicit partition column on the table. Let's just use the same implementation to list primary part columns. ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved partition handling for BigQuery tables, allowing direct retrieval of distinct partition values. - **Bug Fixes** - Added clear error handling for unsupported sub-partition filtering in BigQuery partition queries. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to traour clients the status of staour clientss when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Summary by CodeRabbit