Update JobSubmitter interface to take in clusterName and return submission status #697

kumar-zlai · 2025-04-29T03:57:14Z

Summary

This is needed for agent to be able to track status of submitted jobs and report them back to the orchestration service

Checklist

Added Unit Tests
Covered by existing CI
Integration tested
Documentation update

Summary by CodeRabbit

New Features
- Added support for specifying a custom cluster name when submitting EMR jobs.
Improvements
- Scaling factors for auto-scaling now support decimal values, allowing more precise scaling adjustments.
- Job status methods now return status as a string, making it easier to programmatically track job progress and errors.

…ssion status

coderabbitai · 2025-04-29T03:57:21Z

Walkthrough

The changes update several components to improve the precision and flexibility of scaling parameters and job submission handling. The YarnAutoScalingSpec struct now uses floating-point types for scaling factors. The EMR and Dataproc submitters' status methods now return a String instead of Unit, making job status retrieval explicit. The EMR submitter also allows specifying a cluster name during cluster creation. Additionally, a new constant for cluster names is introduced in the job submitter constants.

Changes

File(s)	Change Summary
`api/thrift/agent.thrift`	Changed `scaleUpFactor` and `scaleDownFactor` in `YarnAutoScalingSpec` from `optional i32` to `double`.
`cloud_aws/src/main/scala/.../EmrSubmitter.scala`	Updated `createClusterRequestBuilder` and `submit` to support optional cluster name; `status` now returns `String`.
`cloud_gcp/src/main/scala/.../DataprocSubmitter.scala`	`status` method now returns `String` with explicit error handling.
`spark/src/main/scala/.../JobSubmitter.scala`	`status` in `JobSubmitter` trait returns `String`; added `ClusterName` constant.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant JobSubmitter
    participant EmrSubmitter
    participant DataprocSubmitter

    User->>JobSubmitter: status(jobId)
    JobSubmitter->>EmrSubmitter: status(jobId) (if EMR)
    EmrSubmitter-->>JobSubmitter: String (job status)
    JobSubmitter->>DataprocSubmitter: status(jobId) (if Dataproc)
    DataprocSubmitter-->>JobSubmitter: String (job status)
    JobSubmitter-->>User: String (job status)

Suggested reviewers

david-zlai
chewy-zlai

Poem

Scaling up with decimal grace,
Cluster names now find their place.
Status returns a string so bright,
No more voids lost in the night.
Code refined, precision grown,
Submit your jobs, let it be known!
🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 2a1a28a and 8a3dabc.

📒 Files selected for processing (4)

api/thrift/agent.thrift (1 hunks)
cloud_aws/src/main/scala/ai/chronon/integrations/aws/EmrSubmitter.scala (3 hunks)
cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (1 hunks)
spark/src/main/scala/ai/chronon/spark/submission/JobSubmitter.scala (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

spark/src/main/scala/ai/chronon/spark/submission/JobSubmitter.scala (2)

cloud_aws/src/main/scala/ai/chronon/integrations/aws/EmrSubmitter.scala (1)

status (212-217)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (1)

status (33-45)

⏰ Context from checks skipped due to timeout of 90000ms (34)

GitHub Check: service_tests
GitHub Check: service_commons_tests
GitHub Check: hub_tests
GitHub Check: hub_tests
GitHub Check: streaming_tests
GitHub Check: streaming_tests
GitHub Check: service_tests
GitHub Check: cloud_gcp_tests
GitHub Check: spark_tests
GitHub Check: groupby_tests
GitHub Check: cloud_gcp_tests
GitHub Check: cloud_aws_tests
GitHub Check: join_tests
GitHub Check: analyzer_tests
GitHub Check: cloud_aws_tests
GitHub Check: online_tests
GitHub Check: groupby_tests
GitHub Check: spark_tests
GitHub Check: online_tests
GitHub Check: flink_tests
GitHub Check: fetcher_tests
GitHub Check: join_tests
GitHub Check: flink_tests
GitHub Check: api_tests
GitHub Check: batch_tests
GitHub Check: fetcher_tests
GitHub Check: orchestration_tests
GitHub Check: scala_compile_fmt_fix
GitHub Check: api_tests
GitHub Check: aggregator_tests
GitHub Check: analyzer_tests
GitHub Check: batch_tests
GitHub Check: orchestration_tests
GitHub Check: aggregator_tests

🔇 Additional comments (8)

spark/src/main/scala/ai/chronon/spark/submission/JobSubmitter.scala (2)

24-24: Interface update to return job status

Updated method signature to return String, aligning with cloud-specific submitters.

112-112: Added new cluster name constant

New ClusterName constant supports the EMR submitter's enhanced cluster naming functionality.

api/thrift/agent.thrift (1)

8-9: Enhanced precision for scaling factors

Changed from integer to double type, enabling fractional scaling values (like 1.5x).

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (2)

33-38: Updated status method to return job state

Implemented the new JobSubmitter contract by returning the job state as a string.

43-43: Added error handling for job status

Returns "UNKNOWN" for job status when API exceptions occur, improving error handling.

cloud_aws/src/main/scala/ai/chronon/integrations/aws/EmrSubmitter.scala (3)

59-69: Added cluster naming flexibility

Enhanced cluster creation to support optional named clusters instead of always using auto-generated UUIDs.

180-183: Updated cluster creation with optional name

Extracts cluster name from submission properties using the new constant.

212-217: Updated status method to return job state

Implemented the JobSubmitter contract by returning the EMR step status as a string.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tchow-zlai · 2025-04-29T18:00:18Z

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala

@@ -30,17 +30,17 @@ case class GeneralJob(

 class DataprocSubmitter(jobControllerClient: JobControllerClient, conf: SubmitterConf) extends JobSubmitter {


should there be an equivalent change for Dataproc to accept clusterName?

It gets set in conf, which should allow us to control it similarly
https://github.com/zipline-ai/chronon/pull/697/files#diff-b4725870e2c1d47332c88a029f3d55b2a0badcf2badc4dd1c8bc7e4b04c605bcR74

…ssion status (#697) ## Summary This is needed for agent to be able to track status of submitted jobs and report them back to the orchestration service ## Checklist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **New Features** - Added support for specifying a custom cluster name when submitting EMR jobs. - **Improvements** - Scaling factors for auto-scaling now support decimal values, allowing more precise scaling adjustments. - Job status methods now return status as a string, making it easier to programmatically track job progress and errors.

…ssion status (#697) ## Summary This is needed for agent to be able to traour clients status of submitted jobs and report them baour clients to the orchestration service ## Cheour clientslist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **New Features** - Added support for specifying a custom cluster name when submitting EMR jobs. - **Improvements** - Scaling factors for auto-scaling now support decimal values, allowing more precise scaling adjustments. - Job status methods now return status as a string, making it easier to programmatically traour clients job progress and errors.

Update JobSubmitter interface to take in clusterName and return submi…

8a3dabc

…ssion status

kumar-zlai requested a review from tchow-zlai April 29, 2025 03:57

tchow-zlai reviewed Apr 29, 2025

View reviewed changes

chewy-zlai approved these changes Apr 30, 2025

View reviewed changes

kumar-zlai merged commit ca6da1c into main Apr 30, 2025
38 checks passed

kumar-zlai deleted the kumar/agent_job_executor branch April 30, 2025 21:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update JobSubmitter interface to take in clusterName and return submission status #697

Update JobSubmitter interface to take in clusterName and return submission status #697

Uh oh!

kumar-zlai commented Apr 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 29, 2025 •

edited

Loading

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

tchow-zlai Apr 29, 2025

Uh oh!

chewy-zlai Apr 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

		@@ -30,17 +30,17 @@ case class GeneralJob(

		class DataprocSubmitter(jobControllerClient: JobControllerClient, conf: SubmitterConf) extends JobSubmitter {

Update JobSubmitter interface to take in clusterName and return submission status #697

Update JobSubmitter interface to take in clusterName and return submission status #697

Uh oh!

Conversation

kumar-zlai commented Apr 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

tchow-zlai Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

chewy-zlai Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kumar-zlai commented Apr 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

chewy-zlai Apr 30, 2025 •

edited

Loading