Skip to content

chore: remove dep on Extensions from TableUtils #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025

Conversation

tchow-zlai
Copy link
Collaborator

@tchow-zlai tchow-zlai commented Apr 22, 2025

Summary

  • TableUtils shouldn't need a dep on Extensions. It's the other way around. We'll just clone the effectivePartitionColumn logic here. Not ideal, but it provides a much more streamlined dep structure.

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Refactor
    • Improved internal handling of query parameters for more concise and maintainable code. No changes to user-facing functionality.
  • Chores
    • Updated build configuration by removing an unused dependency and refining dependency specifications.

Copy link

coderabbitai bot commented Apr 22, 2025

Walkthrough

This change removes a local dependency from the catalog_lib Scala library in the Bazel build configuration and refactors the scanDf method in TableUtils.scala to use a single Option wrapper for the query parameter, simplifying repeated option handling. The import of ai.chronon.spark.Extensions._ is also removed. Additionally, the cloud_gcp/BUILD.bazel file replaces the single //spark:lib dependency with two more specific dependencies: //spark:catalog_lib and //spark:submission_lib. No changes were made to public APIs or exported entities.

Changes

File(s) Change Summary
spark/BUILD.bazel Removed ":lib" from the deps list of the catalog_lib Scala library rule; added Maven Hadoop client API artifact.
cloud_gcp/BUILD.bazel Replaced //spark:lib dependency with //spark:catalog_lib and //spark:submission_lib.
spark/src/main/scala/ai/chronon/.../TableUtils.scala Removed unused import; refactored scanDf to use a single Option wrapper for query and streamlined extraction of partition column and filters.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant TableUtils

    Caller->>TableUtils: scanDf(query, ...)
    alt query provided
        TableUtils->>TableUtils: Wrap query in Option
        TableUtils->>TableUtils: Extract partitionColumn, wheres, selects
    else query not provided
        TableUtils->>TableUtils: Use class-level partitionColumn
    end
    TableUtils->>TableUtils: Construct wheres and selects
    TableUtils->>Caller: Return DataFrame
Loading

Possibly related PRs

  • zipline-ai/chronon#337: Refactors artifact handling to support Maven and Spark repos, related to dependency changes in this PR.

Suggested reviewers

  • piyush-zlai
  • nikhil-zlai
  • david-zlai

Poem

Dependencies trimmed with care,
Options wrapped with code to spare.
Imports dropped, the build refined,
Spark shines clearer, well-defined.
Bazel’s paths now neat and bright—
A coder’s joy, a cleaner sight! ✨🐇

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between b0abd7f and c4429f1.

📒 Files selected for processing (1)
  • spark/BUILD.bazel (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • spark/BUILD.bazel
⏰ Context from checks skipped due to timeout of 90000ms (32)
  • GitHub Check: streaming_tests
  • GitHub Check: streaming_tests
  • GitHub Check: join_tests
  • GitHub Check: join_tests
  • GitHub Check: groupby_tests
  • GitHub Check: groupby_tests
  • GitHub Check: analyzer_tests
  • GitHub Check: analyzer_tests
  • GitHub Check: spark_tests
  • GitHub Check: fetcher_tests
  • GitHub Check: fetcher_tests
  • GitHub Check: batch_tests
  • GitHub Check: batch_tests
  • GitHub Check: spark_tests
  • GitHub Check: service_tests
  • GitHub Check: service_commons_tests
  • GitHub Check: service_tests
  • GitHub Check: cloud_gcp_tests
  • GitHub Check: online_tests
  • GitHub Check: cloud_aws_tests
  • GitHub Check: hub_tests
  • GitHub Check: online_tests
  • GitHub Check: cloud_gcp_tests
  • GitHub Check: hub_tests
  • GitHub Check: cloud_aws_tests
  • GitHub Check: api_tests
  • GitHub Check: api_tests
  • GitHub Check: aggregator_tests
  • GitHub Check: flink_tests
  • GitHub Check: flink_tests
  • GitHub Check: scala_compile_fmt_fix
  • GitHub Check: aggregator_tests

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tchow-zlai tchow-zlai force-pushed the tchow/table-utils-no-dep branch from 02823c7 to 07c846c Compare April 22, 2025 05:00
@tchow-zlai tchow-zlai changed the base branch from main to tchow/submission-stuff April 22, 2025 05:00
@tchow-zlai tchow-zlai force-pushed the tchow/submission-stuff branch from 1e65bd3 to 62fe656 Compare April 22, 2025 18:32
@tchow-zlai tchow-zlai force-pushed the tchow/table-utils-no-dep branch from 2724c4a to 5ab492f Compare April 22, 2025 18:32
Base automatically changed from tchow/submission-stuff to main April 23, 2025 21:15
tchow-zlai and others added 2 commits April 24, 2025 09:22
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>

Co-authored-by: Thomas Chow <[email protected]>
@tchow-zlai tchow-zlai force-pushed the tchow/table-utils-no-dep branch from 439214d to b0abd7f Compare April 24, 2025 16:22
@tchow-zlai tchow-zlai merged commit 5ca0699 into main Apr 25, 2025
37 checks passed
@tchow-zlai tchow-zlai deleted the tchow/table-utils-no-dep branch April 25, 2025 21:46
varant-zlai pushed a commit that referenced this pull request Apr 26, 2025
## Summary

- TableUtils shouldn't need a dep on Extensions. It's the other way
around. We'll just clone the `effectivePartitionColumn` logic here. Not
ideal, but it provides a much more streamlined dep structure.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved internal handling of query parameters for more concise and
maintainable code. No changes to user-facing functionality.
- **Chores**
- Updated build configuration by removing an unused dependency and
refining dependency specifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai pushed a commit that referenced this pull request Apr 27, 2025
## Summary

- TableUtils shouldn't need a dep on Extensions. It's the other way
around. We'll just clone the `effectivePartitionColumn` logic here. Not
ideal, but it provides a much more streamlined dep structure.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved internal handling of query parameters for more concise and
maintainable code. No changes to user-facing functionality.
- **Chores**
- Updated build configuration by removing an unused dependency and
refining dependency specifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary

- TableUtils shouldn't need a dep on Extensions. It's the other way
around. We'll just clone the `effectivePartitionColumn` logic here. Not
ideal, but it provides a much more streamlined dep structure.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved internal handling of query parameters for more concise and
maintainable code. No changes to user-facing functionality.
- **Chores**
- Updated build configuration by removing an unused dependency and
refining dependency specifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

- TableUtils shouldn't need a dep on Extensions. It's the other way
around. We'll just clone the `effectivePartitionColumn` logic here. Not
ideal, but it provides a much more streamlined dep structure.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved internal handling of query parameters for more concise and
maintainable code. No changes to user-facing functionality.
- **Chores**
- Updated build configuration by removing an unused dependency and
refining dependency specifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

- TableUtils shouldn't need a dep on Extensions. It's the other way
around. We'll just clone the `effectivePartitionColumn` logic here. Not
ideal, but it provides a much more streamlined dep structure.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved internal handling of query parameters for more concise and
maintainable code. No changes to user-facing functionality.
- **Chores**
- Updated build configuration by removing an unused dependency and
refining dependency specifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary

- TableUtils shouldn't need a dep on Extensions. It's the other way
around. We'll just clone the `effectivePartitionColumn` logic here. Not
ideal, but it provides a much more streamlined dep structure.

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved internal handling of query parameters for more concise and
maintainable code. No changes to user-facing functionality.
- **Chores**
- Updated build configuration by removing an unused dependency and
refining dependency specifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants