-
Notifications
You must be signed in to change notification settings - Fork 0
chore: remove dep on Extensions from TableUtils #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change removes a local dependency from the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant TableUtils
Caller->>TableUtils: scanDf(query, ...)
alt query provided
TableUtils->>TableUtils: Wrap query in Option
TableUtils->>TableUtils: Extract partitionColumn, wheres, selects
else query not provided
TableUtils->>TableUtils: Use class-level partitionColumn
end
TableUtils->>TableUtils: Construct wheres and selects
TableUtils->>Caller: Return DataFrame
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (32)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
02823c7
to
07c846c
Compare
1e65bd3
to
62fe656
Compare
2724c4a
to
5ab492f
Compare
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
439214d
to
b0abd7f
Compare
Co-authored-by: Thomas Chow <[email protected]>
## Summary - TableUtils shouldn't need a dep on Extensions. It's the other way around. We'll just clone the `effectivePartitionColumn` logic here. Not ideal, but it provides a much more streamlined dep structure. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved internal handling of query parameters for more concise and maintainable code. No changes to user-facing functionality. - **Chores** - Updated build configuration by removing an unused dependency and refining dependency specifications. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - TableUtils shouldn't need a dep on Extensions. It's the other way around. We'll just clone the `effectivePartitionColumn` logic here. Not ideal, but it provides a much more streamlined dep structure. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved internal handling of query parameters for more concise and maintainable code. No changes to user-facing functionality. - **Chores** - Updated build configuration by removing an unused dependency and refining dependency specifications. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - TableUtils shouldn't need a dep on Extensions. It's the other way around. We'll just clone the `effectivePartitionColumn` logic here. Not ideal, but it provides a much more streamlined dep structure. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved internal handling of query parameters for more concise and maintainable code. No changes to user-facing functionality. - **Chores** - Updated build configuration by removing an unused dependency and refining dependency specifications. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - TableUtils shouldn't need a dep on Extensions. It's the other way around. We'll just clone the `effectivePartitionColumn` logic here. Not ideal, but it provides a much more streamlined dep structure. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved internal handling of query parameters for more concise and maintainable code. No changes to user-facing functionality. - **Chores** - Updated build configuration by removing an unused dependency and refining dependency specifications. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - TableUtils shouldn't need a dep on Extensions. It's the other way around. We'll just clone the `effectivePartitionColumn` logic here. Not ideal, but it provides a much more streamlined dep structure. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved internal handling of query parameters for more concise and maintainable code. No changes to user-facing functionality. - **Chores** - Updated build configuration by removing an unused dependency and refining dependency specifications. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
## Summary - TableUtils shouldn't need a dep on Extensions. It's the other way around. We'll just clone the `effectivePartitionColumn` logic here. Not ideal, but it provides a much more streamlined dep structure. ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved internal handling of query parameters for more concise and maintainable code. No changes to user-facing functionality. - **Chores** - Updated build configuration by removing an unused dependency and refining dependency specifications. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- av pr metadata This information is embedded by the av CLI when creating PRs to traour clients the status of staour clientss when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> --------- Co-authored-by: Thomas Chow <[email protected]>
Summary
effectivePartitionColumn
logic here. Not ideal, but it provides a much more streamlined dep structure.Checklist
Summary by CodeRabbit