Skip to content

Fixing failing AWS integration tests #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions api/python/ai/chronon/airflow_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,11 @@ def _get_airflow_deps_from_source(source, partition_column=None):


def extract_default_partition_column(obj):
return obj.metaData.executionInfo.conf.common.get("spark.chronon.partition.column")

try:
return obj.metaData.executionInfo.conf.common.get("spark.chronon.partition.column")
except Exception:
# Error handling occurs in `create_airflow_dependency`
return None

def _set_join_deps(join):
default_partition_col = extract_default_partition_column(join)
Expand Down
5 changes: 5 additions & 0 deletions api/python/test/canary/teams.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@
description="Default team",
email="ml-infra@<customer>.com", # TODO: Infra team email
outputNamespace="default",
conf=ConfigProperties(
common={
"spark.chronon.partition.column": "ds",
}
),
env=EnvironmentVariables(
common={
"VERSION": "latest",
Expand Down
9 changes: 3 additions & 6 deletions api/thrift/agent.thrift
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
namespace java ai.chronon.api
include "common.thrift"

// TODO: Need to brainstorm and make necessary changes. just a starting point to unblock other work.
struct YarnAutoScalingSpec {
Expand Down Expand Up @@ -33,7 +34,7 @@ struct YarnJob {
1: optional string appName
2: optional YarnJobType jobType

10: optional list<string> args
10: optional list<string> argsList
11: optional map<string, string> env
12: optional map<string, string> conf
// creates local file with this name and contents - relative to cwd
Expand Down Expand Up @@ -121,13 +122,9 @@ struct JobInfo {
10: optional YarnIncrementalJobStatus yarnIncrementalStatus
}

struct DatePartitionRange {
1: optional string start
2: optional string end
}

struct PartitionListingPutRequest {
1: optional map<PartitionListingJob, list<DatePartitionRange>> partitions
1: optional map<PartitionListingJob, list<common.DateRange>> partitions
2: optional map<PartitionListingJob, string> errors
}

Expand Down