GCP Integration Tests Catch Failures

[chewy-zlai]

Summary

Right now, the gcp integration tests do not recognize failures from dataproc and continue running the commands. This has led to the group_by_upload job hanging indefinitely. This change ensures that if the dataproc job state is "ERROR" we fail immediately.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Bug Fixes
  • Enhanced job status checking by ensuring that both empty and explicitly error-indicating states trigger consistent failure responses, resulting in more robust job evaluation.

[coderabbitai]

Walkthrough

The pull request updates the check_dataproc_job_state function in the script. It now uses an awk command to extract the last field from the grep output, ensuring that JOB_STATE holds only the state value. The condition has been expanded to treat an empty or "ERROR" state as a failure, triggering the same error handling behavior.

Changes

File	Change Summary
scripts/distribution/run_gcp_quickstart.sh	Updated check_dataproc_job_state to extract the last field with awk and to check for empty or "ERROR" states.

Sequence Diagram(s)

sequenceDiagram
    participant S as Script
    S->>S: Run check_dataproc_job_state
    S->>S: Execute grep then awk extraction for JOB_STATE
    alt JOB_STATE empty or "ERROR"
        S->>S: Print error message & exit
    else
        S->>S: Continue execution
    end

Loading

Suggested reviewers

• david-zlai
• tchow-zlai

Poem

In the script, a twist so light,
Awk refines the job state right.
Empty or "ERROR" now alert,
Exiting fast when things divert.
Code refined with a subtle art,
Cheers to progress—a fresh new start!
🚀🌟

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

scripts/distribution/run_gcp_quickstart.sh (1)

60-64: Improve error detection.
The updated condition now fails the script if JOB_STATE is empty or "ERROR". Consider removing the now-obsolete TODO comment on line 60.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f3acb8e and 85a2412.

📒 Files selected for processing (1)

• scripts/distribution/run_gcp_quickstart.sh (1 hunks)

🔇 Additional comments (1)

scripts/distribution/run_gcp_quickstart.sh (1)

58-59: Extract JOB_STATE correctly.
Using awk '{print $NF}' ensures only the state value is captured.