Summary upload #50
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,8 +29,8 @@ | |
| __version__ = "local" | ||
| __branch__ = "main" | ||
| def get_version(): | ||
| version_str = os.environ.get("VERSION", __version__) | ||
| branch_str = os.environ.get("BRANCH", __branch__) | ||
|
There was a problem hiding this comment. 💡 Codebase verification Update required in python-api-build.sh script for environment variable changes The verification has identified that
🔗 Analysis chainEnvironment variable names have been simplified. The change to use simpler environment variable names ( Let's verify the impact of this change: Consider the following to ensure a smooth transition:
Would you like me to help create a GitHub issue to track these tasks? Let me check the content of the identified shell script to understand the impact better. Let me check if there are any CI/CD configuration files that might be using these environment variables. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any references to the old environment variable names
# that need to be updated.
echo "Checking for old environment variable references..."
rg -l "CHRONON_VERSION_STR|CHRONON_BRANCH_STR"
echo "Checking for any shell scripts that might be setting these variables..."
fd -e sh -x grep -l "CHRONON_VERSION_STR|CHRONON_BRANCH_STR" {}
Length of output: 409 Script: #!/bin/bash
# Check the content of the build script that uses these variables
cat api/py/python-api-build.sh
Length of output: 2204 Script: #!/bin/bash
# Check for CI/CD configuration files that might reference these variables
echo "Checking GitHub Actions workflows..."
fd -e yml -e yaml -p '.github/workflows' -x grep -l "CHRONON_VERSION_STR\|CHRONON_BRANCH_STR" {}
echo "Checking for other potential CI/CD configs..."
fd -e yml -e yaml -x grep -l "CHRONON_VERSION_STR\|CHRONON_BRANCH_STR" {}
echo "Checking for any Dockerfiles..."
fd Dockerfile -x grep -l "CHRONON_VERSION_STR\|CHRONON_BRANCH_STR" {}
Length of output: 507 |
||
| # Replace "-SNAPSHOT" with ".dev" | ||
| version_str = version_str.replace("-SNAPSHOT", ".dev") | ||
| # If the prefix is the branch name, then convert it as suffix after '+' to make it Python PEP440 complaint | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -275,7 +275,9 @@ object Builders { | |
| result.setProduction(production) | ||
| result.setCustomJson(customJson) | ||
| result.setOutputNamespace(namespace) | ||
| val effectiveTeam = Option(team).getOrElse(name.split("\\.").headOption.getOrElse("chronon")) | ||
|
|
||
| result.setTeam(effectiveTeam) | ||
| result.setHistoricalBackfill(historicalBackill) | ||
| if (dependencies != null) | ||
| result.setDependencies(dependencies.toSeq.toJava) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,7 @@ object Constants { | |
| val MutationAvroFields: Seq[StructField] = Seq(TimeField, ReversalField) | ||
| val MutationAvroColumns: Seq[String] = MutationAvroFields.map(_.name) | ||
| val MutationFields: Seq[StructField] = Seq(MutationTimeField, ReversalField) | ||
| val TileColumn: String = "_tile" | ||
| val TimedKvRDDKeySchemaKey: String = "__keySchema" | ||
| val TimedKvRDDValueSchemaKey: String = "__valueSchema" | ||
| val StatsKeySchema: StructType = StructType("keySchema", Array(StructField("JoinPath", StringType))) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,14 +43,16 @@ object Extensions { | |
| implicit class TimeUnitOps(timeUnit: TimeUnit) { | ||
| def str: String = | ||
| timeUnit match { | ||
| case TimeUnit.HOURS => "h" | ||
| case TimeUnit.DAYS => "d" | ||
| case TimeUnit.MINUTES => "m" | ||
| } | ||
|
|
||
| def millis: Long = | ||
| timeUnit match { | ||
| case TimeUnit.HOURS => 3600 * 1000 | ||
| case TimeUnit.DAYS => 24 * 3600 * 1000 | ||
| case TimeUnit.MINUTES => 60 * 1000 | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -108,6 +110,9 @@ object Extensions { | |
| def outputFinalView: String = s"${metaData.outputNamespace}.${metaData.cleanName}_labeled" | ||
| def outputLatestLabelView: String = s"${metaData.outputNamespace}.${metaData.cleanName}_labeled_latest" | ||
| def loggedTable: String = s"${outputTable}_logged" | ||
| def summaryTable: String = s"${outputTable}_summary" | ||
| def packedSummaryTable: String = s"${outputTable}_summary_packed" | ||
| def driftTable: String = s"${outputTable}_drift" | ||
|
|
||
| def bootstrapTable: String = s"${outputTable}_bootstrap" | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider parameter validation and functional improvements.
While the documentation is good, the method could benefit from parameter validation and a more functional approach.
Consider these improvements:
def PSIKllSketch(reference: AnyRef, comparison: AnyRef, bins: Int = 20, eps: Double = 0.000001): AnyRef = { + require(bins > 0, "Number of bins must be positive") + require(eps > 0, "Epsilon must be positive") if (reference == null || comparison == null) return None val referenceSketch = KllFloatsSketch.heapify(Memory.wrap(reference.asInstanceOf[Array[Byte]])) val comparisonSketch = KllFloatsSketch.heapify(Memory.wrap(comparison.asInstanceOf[Array[Byte]])) val binsToDoubles = (0 to bins).map(_.toDouble / bins).toArray val keySet = referenceSketch.getQuantiles(binsToDoubles).union(comparisonSketch.getQuantiles(binsToDoubles)).distinct.sorted val referencePMF = regularize(referenceSketch.getPMF(keySet), eps) val comparisonPMF = regularize(comparisonSketch.getPMF(keySet), eps) - var psi = 0.0 - for (i <- referencePMF.indices) { - psi += (referencePMF(i) - comparisonPMF(i)) * Math.log(referencePMF(i) / comparisonPMF(i)) - } - psi.asInstanceOf[AnyRef] + referencePMF.zip(comparisonPMF) + .map { case (ref, comp) => (ref - comp) * Math.log(ref / comp) } + .sum + .asInstanceOf[AnyRef]Also applies to: 170-173