-
Notifications
You must be signed in to change notification settings - Fork 0
fix: remove references to custom json, float essential apis to top #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
6e99aab
c4b1c9c
9322e9a
b270494
b533d2c
1bb7c0c
4604e61
08e3315
4c75619
e8983b5
60982bb
93f183a
99e98fa
45b8964
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -249,13 +249,19 @@ struct MetaData { | |
|
||
4: optional string outputNamespace | ||
|
||
5: optional map<string, string> tableProperties | ||
/** | ||
* By default we will just partition the output by the date column - set via "spark.chronon.partition.column" | ||
* With this we will partition the output with the specified additional columns | ||
**/ | ||
5: optional list<string> additionalOutputPartitionColumns | ||
|
||
6: optional map<string, string> tableProperties | ||
|
||
// tag_key -> tag_value - tags allow for repository wide querying, deprecations etc | ||
// this is object level tag - applies to all columns produced by the object - GroupBy, Join, Model etc | ||
6: optional map<string, string> tags | ||
20: optional map<string, string> tags | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Field number here too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the spacing in field nums allows for adding things new fields in the right order. so if we find some other thing later, we can add it in the right place instead of in the end. |
||
// column -> tag_key -> tag_value | ||
7: optional map<string, map<string, string>> columnTags | ||
21: optional map<string, map<string, string>> columnTags | ||
|
||
// marking this as true means that the conf can be served online | ||
// once marked online, a conf cannot be changed - compiling the conf won't be allowed | ||
|
@@ -286,8 +292,6 @@ struct MetaData { | |
204: optional common.ExecutionInfo executionInfo | ||
} | ||
|
||
|
||
|
||
// Equivalent to a FeatureSet in chronon terms | ||
struct GroupBy { | ||
1: optional MetaData metaData | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep tableProperties the same field number as before (5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought outputPartitionCols are more important than table props. Safe to change these for now actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should call out that folks need to recompile their existing configs right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call - we need to release a wheel and cut them over. was working on it separately. (basically I am doing the compile for them)