chore: remove writeFormat as it is no longer used

[tchow-zlai]

Summary

• Remove writeFormat. We now just create the table with the proper provider, and write into it as specified by the table.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Removed legacy support for custom data write formatting and configuration.
  • Eliminated extended data pointer handling for saving and loading operations.
  • Streamlined table write operations by discarding redundant prefix and format determination logic.
  • Enhanced input validation for table types in the table creation process.
  • Simplified BigQueryFormat and GCSFormat by removing unsupported methods.
  • Removed unnecessary methods from DeltaLake, Hive, and Iceberg format implementations.

[coderabbitai]

Walkthrough

This pull request removes the write functionality from multiple components. The writeFormat method is eliminated from the format provider classes (GcpFormatProvider, DefaultFormatProvider) and the FormatProvider trait. Additionally, the CatalogAwareDataPointer class along with its related methods and the implicit DataFrame extensions for read/write via DataPointer have been removed. The write prefix logic in TableUtils is also dropped. Remaining functionality retains read operations and table name resolution.

Changes

File(s)	Change Summary
cloud_gcp/src/.../GcpFormatProvider.scala, spark/src/.../DefaultFormatProvider.scala, spark/src/.../FormatProvider.scala	Removed writeFormat methods from format provider implementations/traits.
spark/src/.../CatalogAwareDataPointer.scala	Removed entire class and all methods for DataPointer handling.
spark/src/.../Extensions.scala	Removed implicit classes for DataFrame read/write operations using DataPointer.
spark/src/.../TableUtils.scala	Removed the writePrefix variable used for determining table write paths.
cloud_gcp/src/.../BigQueryFormat.scala, cloud_gcp/src/.../GCSFormat.scala, spark/src/.../DeltaLake.scala, spark/src/.../Hive.scala, spark/src/.../Iceberg.scala	Removed unsupported methods related to table creation and format handling.

Possibly related PRs

• feat: TableUtils to be compatible with DataPointer (part 1) #158: Involves removal of the writeFormat method from the GcpFormatProvider, related to broader changes in write functionality.
• chore: Refactor out Format abstractions #145: Involves the removal of the writeFormat method from the FormatProvider trait, indicating a direct connection at the code level.
• feat: CatalogAwareDataPointer and refactoring existing DataPointer #157: Involves removal of the writeFormat method from the DataPointer interface, aligning with these changes.

Suggested reviewers

• nikhil-zlai
• piyush-zlai
• varant-zlai
• david-zlai

Poem

In code we trim the write and clear,
Old paths vanish, new ones appear.
Data flows now read with ease,
Clean lines bring a coding breeze.
🎉 CodeRabbit’s spirit shines so bright,
A refactored future taking flight!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 916c39a and 1b335d7.

📒 Files selected for processing (6)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala (1 hunks)
• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GCSFormat.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/format/DeltaLake.scala (0 hunks)
• spark/src/main/scala/ai/chronon/spark/format/Format.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/format/Hive.scala (0 hunks)
• spark/src/main/scala/ai/chronon/spark/format/Iceberg.scala (0 hunks)

💤 Files with no reviewable changes (3)

• spark/src/main/scala/ai/chronon/spark/format/Hive.scala
• spark/src/main/scala/ai/chronon/spark/format/Iceberg.scala
• spark/src/main/scala/ai/chronon/spark/format/DeltaLake.scala

🧰 Additional context used

🧠 Learnings (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala (2)

Learnt from: tchow-zlai
PR: zipline-ai/chronon#263
File: cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala:29-60
Timestamp: 2025-01-24T23:55:30.256Z
Learning: In BigQuery integration, table existence check is performed outside the BigQueryFormat.createTable method, at a higher level in TableUtils.createTable.

Learnt from: tchow-zlai
PR: zipline-ai/chronon#263
File: cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala:56-57
Timestamp: 2025-01-24T23:55:40.650Z
Learning: For BigQuery table creation operations in BigQueryFormat.scala, allow exceptions to propagate directly without wrapping them in try-catch blocks, as the original BigQuery exceptions provide sufficient context.

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: streaming_tests
• GitHub Check: spark_tests
• GitHub Check: groupby_tests
• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: join_tests
• GitHub Check: join_tests
• GitHub Check: groupby_tests
• GitHub Check: fetcher_tests
• GitHub Check: analyzer_tests
• GitHub Check: spark_tests
• GitHub Check: fetcher_tests
• GitHub Check: non_spark_tests
• GitHub Check: non_spark_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (3)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GCSFormat.scala (1)

8-8: Import cleanup confirmed.

Removed DataFrame import since it's no longer used after writeFormat removal.

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/BigQueryFormat.scala (1)

8-8: Import cleanup confirmed.

DataFrame import properly removed following writeFormat removal.

spark/src/main/scala/ai/chronon/spark/format/Format.scala (1)

5-5: Import cleanup confirmed.

Simplified imports after removing writeFormat-related functionality.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.