Stop using cloud_gcp_submitter jar and just use cloud_gcp jar, and add --gcp for fetch
#466
Conversation
WalkthroughThis pull request updates the GCP integration for Chronon. Import paths are revised and the constant is renamed for clarity. The jar URI generation logic in both Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant R as run.py
participant G as generate_dataproc_submitter_args
U->>R: Execute CLI with --gcp flag
R->>G: Request jar URI generation
G-->>R: Return jar URI (using ZIPLINE_GCP_JAR_DEFAULT)
R->>U: Submit job with proper jar URI
sequenceDiagram
participant B as build_wheel.sh
participant T as Thrift Compiler
participant P as Pip
B->>T: Generate Python for common.thrift
B->>T: Generate Python for api.thrift
B->>T: Generate Python for observability.thrift
T-->>B: Python code generated
B->>P: Build wheel package with supplied version
P-->>B: Wheel built
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
david-zlai
force-pushed
the
davidhan/remove_submitter_jar
branch
from
c3c6276 to
f985c36
Compare
david-zlai
force-pushed
the
davidhan/remove_submitter_jar
branch
from
f985c36 to
1949cb7
Compare
| elif chronon_jar: | ||
| jar_path = chronon_jar | ||
| else: | ||
| if dataproc or gcp: |
There was a problem hiding this comment.
I regret not naming this gcp to begin with. Adding gcp as an option because when users run fetch, technically there's no Dataproc involvement.
Currently it looks like this:
zipline run --mode fetch --conf-type group_bys --name quickstart.purchases.v1 -k '{"user_id":"5"}'
but once we onboard plaid who uses aws, we do need to include in the command which cloud provider is being used.
So moving forward the new fetch command will look like this:
zipline run --mode fetch --conf-type group_bys --name quickstart.purchases.v1 -k '{"user_id":"5"}' --gcp
There was a problem hiding this comment.
is this something that we could set as part of teams.py by any chance? cc @nikhil-zlai. Feels like this is a one-time permanent setting.
There was a problem hiding this comment.
yeah, actually we could set something like CLOUD_PROVIDER
There was a problem hiding this comment.
@tchow-zlai , mind if I do this in a follow up PR?
david-zlai
force-pushed
the
davidhan/remove_submitter_jar
branch
from
27fd158 to
70ea38e
Compare
david-zlai
changed the title
fetch
david-zlai
changed the title
fetch--gcp for fetch
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
scripts/distribution/build_wheel.sh (1)
5-6: 🛠️ Refactor suggestionAdd parameter validation
Missing validation for required version parameter.
-VERSION=$1 pip wheel api/py +if [ -z "$1" ]; then + echo "Error: Version parameter is required" + echo "Usage: $0 <version>" + exit 1 +fi + +VERSION=$1 pip wheel api/py
🧹 Nitpick comments (1)
scripts/distribution/build_wheel.sh (1)
1-3: Add error handling for thrift commandsNo error checking for thrift command failures.
+#!/bin/bash +set -eo pipefail + +# Generate Python code from Thrift definitions thrift --gen py -out api/py/ api/thrift/common.thrift thrift --gen py -out api/py/ api/thrift/api.thrift thrift --gen py -out api/py/ api/thrift/observability.thrift🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
⛔ Files ignored due to path filters (1)
docs/source/dev/img.pngis excluded by!**/*.png
📒 Files selected for processing (7)
api/py/ai/chronon/repo/gcp.py(2 hunks)api/py/ai/chronon/repo/run.py(6 hunks)cloud_gcp/BUILD.bazel(0 hunks)docs/source/dev/devnotes.md(15 hunks)scripts/distribution/build_and_upload_artifacts.sh(1 hunks)scripts/distribution/build_wheel.sh(1 hunks)scripts/distribution/run_zipline_quickstart.sh(2 hunks)
💤 Files with no reviewable changes (1)
- cloud_gcp/BUILD.bazel
🧰 Additional context used
🪛 Shellcheck (0.10.0)
scripts/distribution/build_wheel.sh
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
🪛 LanguageTool
docs/source/dev/devnotes.md
[uncategorized] ~75-~75: Consider adding a hyphen.
Context: ...ile - We should see a bazel icon in the top right corner to the left of search bar - ...
(TOP_LEFT_CORNER)
[uncategorized] ~83-~83: Possible missing comma found.
Context: ...cal development and CI. As part of that change we would need to do gcloud auth to read...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~88-~88: Possible missing comma found.
Context: ....local file with the following content. Also feel free to specify any local override...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~99-~99: Possible missing comma found.
Context: ...don't have to resolve them during build time which can take up a very long time at t...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~118-~118: Possible missing comma found.
Context: ...error on Mac In case you run into this error the fix is to manually download and ins...
(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~146-~146: To elevate your writing, try using a synonym like ‘required’ here. Or, to avoid using the passive voice, try replacing the past participle ‘needed’ with an adjective.
Context: ...oy.jar" is bazel specific suffix that's needed for building uber jar with all > transi...
(IS_NEEDED_NECESSARY)
[uncategorized] ~151-~151: A comma may be missing after the conjunctive/linking adverb ‘Also’.
Context: ...n ### All tests for a specific module Also it's lot easier to just run from Intell...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~211-~211: Possible missing article found.
Context: ...` > Note: The quotes are necessary for multi-word commit message. ## Connect remote...
(AI_HYDRA_LEO_MISSING_A)
[style] ~219-~219: In American English, abbreviations like “etc.” require a period.
Context: ... in the frontend is run (i.e. api call, etc) To connect to the process within the ...
(ETC_PERIOD)
[uncategorized] ~232-~232: Possible missing comma found.
Context: ..., step through the code, etc. For more details see IntelliJ remote debugging [tutorial...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~241-~241: Possible missing comma found.
Context: ...IDEA > Settings > Editor > Code Style > Scala enable scalafmt. - Follow the steps b...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~249-~249: Did you mean “copying and pasting”?
Context: ...-fails-with-illegalaccesserror-cl) by copy pasting into the run configuration arguments li...
(COPY_PASTE)
[style] ~331-~331: Consider removing “of” to be more concise
Context: ... directory. ## Using sbt ### To build all of the Chronon artifacts locally (builds all t...
(ALL_OF_THE)
[uncategorized] ~343-~343: When ‘version-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...This will create the artifacts with the version specific naming specified under version.sbt `...
(SPECIFIC_HYPHEN)
[grammar] ~414-~414: Did you mean Apple’s computer “Mac” (= trademark, capitalized)?
Context: ...he email. 2. brew install gpg on your mac 3. In ~/.sbt/1.0/sonatype.sbt add ``...
(APPLE_PRODUCTS)
[grammar] ~435-~435: This sentence should probably be started with a verb instead of the noun ‘Setup’. If not, consider inserting a comma for better clarity.
Context: ...thon API package to PyPi repository 1. Setup your pypi public account and contact @n...
(SENT_START_NN_DT)
[uncategorized] ~439-~439: Possible missing comma found.
Context: ... * tox: Module for testing. To run the tests run tox in the main project directory. ...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~440-~440: Possible missing comma found.
Context: ...ctory. * build: Module for building. To build run python -m build in the main proje...
(AI_HYDRA_LEO_MISSING_COMMA)
[formatting] ~448-~448: Consider adding a comma after ‘Normally’ for more clarity.
Context: ...for the python repositories you manage. Normally in ~/.pypirc ``` [distutils] index...
(CONJUNCTIVE_LINKING_ADVERB_COMMA_PREMIUM)
[uncategorized] ~488-~488: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...(git commits). * Creates a new git tag (e.g v0.7.0) pointing to the release commit....
(E_G)
[uncategorized] ~490-~490: It appears that a hyphen is missing if you mean the adjective “in-line”.
Context: ... the version.sbt to point to the next in line developmental version (git commits). 2...
(IN_CAR_HYPHEN)
[grammar] ~494-~494: Did you mean the noun “publishing”?
Context: ...In the staging repos list - select your publish 1. select "close" wait for the step...
(PREPOSITION_VERB)
[uncategorized] ~519-~519: Possible missing article found.
Context: ... the latest. ### Troubleshooting * Most common reason for Python failure is re-...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~523-~523: A comma may be missing after the conjunctive/linking adverb ‘Currently’.
Context: ... that can backfill, upload, stream etc. Currently the repo is not public and the run.py s...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~561-~561: Possible missing comma found.
Context: ...ell /usr/local/bin/amm In the repl prompt load the jar scala import $cp.spark...
(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~572-~572: The negated form ‘not’ seems to be incomplete.
Context: ...h just this directory will help the IDE not get confused when resolving imports lik...
(DT_NN_NOT_VB)
[uncategorized] ~572-~572: A comma may be missing after the conjunctive/linking adverb ‘Also’.
Context: ... the java or scala modules instead. Also helpful tip: `Invalidated Caches / Rest...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
🪛 markdownlint-cli2 (0.17.2)
docs/source/dev/devnotes.md
73-73: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
73-73: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
74-74: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
74-74: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
75-75: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
76-76: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
76-76: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
77-77: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
77-77: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
78-78: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
92-92: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
239-239: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
240-240: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
241-241: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
242-242: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
245-245: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
270-270: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
276-276: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
280-280: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
293-293: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
408-408: Bare URL used
null
(MD034, no-bare-urls)
423-423: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
443-443: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
481-481: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
506-506: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
510-510: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
513-513: Bare URL used
null
(MD034, no-bare-urls)
530-530: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
🔇 Additional comments (14)
scripts/distribution/run_zipline_quickstart.sh (1)
92-92: Updated command to use GCP flagCommand now properly includes GCP flag for fetch operation.
docs/source/dev/devnotes.md (3)
41-42: Improved formatting for claritySplit note about Scala and Java versions into separate lines.
83-84: Improved sentence structureSplit long sentence about remote caching into multiple lines.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~83-~83: Possible missing comma found.
Context: ...cal development and CI. As part of that change we would need to do gcloud auth to read...(AI_HYDRA_LEO_MISSING_COMMA)
118-119: Fixed documentation linkBetter formatted link to Corretto download page.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~118-~118: Possible missing comma found.
Context: ...error on Mac In case you run into this error the fix is to manually download and ins...(AI_HYDRA_LEO_MISSING_COMMA)
scripts/distribution/build_and_upload_artifacts.sh (1)
115-115: Simplified wheel buildingReplaced multiple thrift commands with call to dedicated script.
api/py/ai/chronon/repo/gcp.py (4)
7-8: Updated import pathUsing full import path improves clarity and resolves potential ambiguity.
12-12: Renamed constant for clarityUpdated constant name aligns with PR goal to eliminate submitter jar references.
170-170: Updated JAR referenceNow referencing the renamed constant for jar path.
176-177: Improved string formattingBetter line continuation for string concatenation.
api/py/ai/chronon/repo/run.py (5)
30-33: Absolute imports improve code maintainabilitySwitching to absolute imports provides better clarity and maintainability.
784-784: New--gcpflag enables cloud provider selectionAddition of the
--gcpflag allows users to specify which cloud provider's implementations to use during fetch operations.
794-796: Default changed to useZIPLINE_GCP_JAR_DEFAULTUpdated default to use the consolidated GCP jar instead of the separate submitter jar.
819-823: Updated function signature to include the new flagFunction signature updated to include the
gcpparameter, correctly reflecting the new command-line option.
832-841:❓ Verification inconclusive
Simplified jar path logic and improved error handling
The updated conditional now considers both
dataprocandgcpflags, eliminating separate handling for the submitter jar. The error check for jar path is a good addition.
🏁 Script executed:
#!/bin/bash # Verify no references to cloud_gcp_submitter remain in the codebase rg "cloud_gcp_submitter" --type pyLength of output: 34
Review Approved – Please Verify Manually
- The conditional now correctly consolidates both
dataprocandgcphandling.- The jar path error check is appropriate.
- No references to
cloud_gcp_submitterwere detected; please manually verify this if needed.
| @@ -0,0 +1,5 @@ | |||
| thrift --gen py -out api/py/ api/thrift/common.thrift | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add a shebang line
Missing interpreter directive at the beginning of the script.
+#!/bin/bash
thrift --gen py -out api/py/ api/thrift/common.thrift📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| thrift --gen py -out api/py/ api/thrift/common.thrift | |
| #!/bin/bash | |
| thrift --gen py -out api/py/ api/thrift/common.thrift |
🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
| @@ -49,6 +49,7 @@ function check_dataproc_job_state() { | |||
| echo -e "${GREEN} <<<<<<<<<<<<<<<<-----------------JOB STATUS----------------->>>>>>>>>>>>>>>>>\033[0m" | |||
| JOB_STATE=$(gcloud dataproc jobs describe $JOB_ID --region=us-central1 --format=flattened | grep "status.state:") | |||
| echo $JOB_STATE | |||
| # TODO: this doesn't actually fail. need to fix. | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Fix failure detection in job state check
Current TODO indicates known issue with failure detection logic.
🏁 Script executed:
#!/bin/bash
# Check how the job state logic works and why it doesn't fail properly
echo "Examining job state check..."
grep -A 10 "check_dataproc_job_state" scripts/distribution/run_zipline_quickstart.shLength of output: 2535
Fix job state failure detection in check_dataproc_job_state
- In
scripts/distribution/run_zipline_quickstart.sh, update the failure check so that an emptyJOB_STATEcorrectly exits (e.g., add anexit 1after the empty-state check). - The TODO comment on line 52 still applies.
| ZIPLINE_GCP_ONLINE_CLASS_DEFAULT = "ai.chronon.integrations.cloud_gcp.GcpApiImpl" | ||
| ZIPLINE_GCP_FLINK_JAR_DEFAULT = "flink_assembly_deploy.jar" | ||
| ZIPLINE_GCP_DATAPROC_SUBMITTER_JAR = "cloud_gcp_submitter_deploy.jar" |
There was a problem hiding this comment.
what do we invoke instead? just the default jar?
There was a problem hiding this comment.
sounds good, wondering if that's gonna be pretty heavy to download the large jar every time
There was a problem hiding this comment.
should be doing the hash check to only download if the hashes don't match
| @@ -0,0 +1,5 @@ | |||
| thrift --gen py -out api/py/ api/thrift/common.thrift | |||
There was a problem hiding this comment.
can we use bazel for this?
There was a problem hiding this comment.
mmm maybe. for now i'm just sectioning this off separately so I can call it whenever I want
There was a problem hiding this comment.
looks like we don't have it set up to generate the python. Nvm I thought we did.
…d `--gcp` for `fetch` (#466) ## Summary ^^^ Removing usage and references to the cloud_gcp_submitter jar as we don't need it. And added an additional `--gcp` arg so that it can be used in the `fetch` command to set which cloud provider's implementations we should use. Ex: `fetch` + `--gcp` should be pulling from the `BigTable` kv store code ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a new command-line option for specifying GCP settings, allowing users to easily switch modes. - Introduced an automated script for creating Python wheel packages during artifact builds. - **Refactor** - Updated module imports and renamed constants for improved clarity and consistency. - Simplified logic for handling jar file paths and streamlined the artifact build process. - Removed obsolete build configurations and redundant commands. - **Documentation** - Enhanced developer notes with improved formatting for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…d `--gcp` for `fetch` (#466) ## Summary ^^^ Removing usage and references to the cloud_gcp_submitter jar as we don't need it. And added an additional `--gcp` arg so that it can be used in the `fetch` command to set which cloud provider's implementations we should use. Ex: `fetch` + `--gcp` should be pulling from the `BigTable` kv store code ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a new command-line option for specifying GCP settings, allowing users to easily switch modes. - Introduced an automated script for creating Python wheel packages during artifact builds. - **Refactor** - Updated module imports and renamed constants for improved clarity and consistency. - Simplified logic for handling jar file paths and streamlined the artifact build process. - Removed obsolete build configurations and redundant commands. - **Documentation** - Enhanced developer notes with improved formatting for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…d `--gcp` for `fetch` (#466) ## Summary ^^^ Removing usage and references to the cloud_gcp_submitter jar as we don't need it. And added an additional `--gcp` arg so that it can be used in the `fetch` command to set which cloud provider's implementations we should use. Ex: `fetch` + `--gcp` should be pulling from the `BigTable` kv store code ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a new command-line option for specifying GCP settings, allowing users to easily switch modes. - Introduced an automated script for creating Python wheel packages during artifact builds. - **Refactor** - Updated module imports and renamed constants for improved clarity and consistency. - Simplified logic for handling jar file paths and streamlined the artifact build process. - Removed obsolete build configurations and redundant commands. - **Documentation** - Enhanced developer notes with improved formatting for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…d `--gcp` for `fetch` (#466) ## Summary ^^^ Removing usage and references to the cloud_gcp_submitter jar as we don't need it. And added an additional `--gcp` arg so that it can be used in the `fetch` command to set which cloud provider's implementations we should use. Ex: `fetch` + `--gcp` should be pulling from the `BigTable` kv store code ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a new command-line option for specifying GCP settings, allowing users to easily switch modes. - Introduced an automated script for creating Python wheel packages during artifact builds. - **Refactor** - Updated module imports and renamed constants for improved clarity and consistency. - Simplified logic for handling jar file paths and streamlined the artifact build process. - Removed obsolete build configurations and redundant commands. - **Documentation** - Enhanced developer notes with improved formatting for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…d `--gcp` for `fetch` (#466) ## Summary ^^^ Removing usage and references to the cloud_gcp_submitter jar as we don't need it. And added an additional `--gcp` arg so that it can be used in the `fetch` command to set which cloud provider's implementations we should use. Ex: `fetch` + `--gcp` should be pulling from the `BigTable` kv store code ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added a new command-line option for specifying GCP settings, allowing users to easily switch modes. - Introduced an automated script for creating Python wheel paour clientsages during artifact builds. - **Refactor** - Updated module imports and renamed constants for improved clarity and consistency. - Simplified logic for handling jar file paths and streamlined the artifact build process. - Removed obsolete build configurations and redundant commands. - **Documentation** - Enhanced developer notes with improved formatting for better readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
^^^
Removing usage and references to the cloud_gcp_submitter jar as we don't need it. And added an additional
--gcparg so that it can be used in thefetchcommand to set which cloud provider's implementations we should use. Ex:fetch+--gcpshould be pulling from theBigTablekv store codeChecklist
Summary by CodeRabbit
New Features
Refactor
Documentation