Skip to content

cleanup: remove unused files/dirs from the top level #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

nikhil-zlai
Copy link
Contributor

@nikhil-zlai nikhil-zlai commented Feb 27, 2025

Summary

cleaning up top level dir

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Chores
    • Refined version control and build settings by updating ignored paths and tool versions.
    • Removed obsolete internal configurations, tooling, and Docker build files for a cleaner project structure.
  • Documentation
    • Updated installation guidance links for clearer setup instructions.
    • Eliminated legacy contributor, governance, and quickstart guides to reduce clutter.

Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

The pull request updates the ignored node modules path in the top-level .gitignore, removes plugin entries and version declarations from configuration files, and deletes several configuration, documentation, build, and source code files. The changes affect Scalafix rules, project authorship, contribution guidelines, licensing, Docker setups, and MongoDB online implementations, along with adjustments to Docker Compose paths and README links.

Changes

File(s) Summary
.gitignore, quickstart/.../.gitignore Updated ignore patterns: switched ignored directory from /authoring/vscode/node_modules to /plugins/vscode/node_modules; removed ignored entries for /bsp/ and target/ in quickstart.
.plugin-versions, .tool-versions Removed entries for java and sbt in .plugin-versions and deleted specific Java/Python version lines in .tool-versions.
.scalafix.conf, AUTHORS, CONTRIBUTING.md, GOVERNANCE.md, LICENSE Removed configuration and documentation files covering code formatting, authorship, contributions, governance, and licensing.
docker-compose.yml, docker-init/README.md, quickstart/README.md, quickstart/Dockerfile, quickstart/.env.spark, quickstart/requirements.txt, scripts/cloud_gcp_quickstart/gcp-docker-compose.yml Deleted Docker compose and related quickstart files; updated README link and modified dockerfile paths in cloud quickstart.
project/build.properties, project/plugins.sbt, quickstart/mongo-online-impl/build.sbt, quickstart/mongo-online-impl/project/build.properties, quickstart/mongo-online-impl/project/plugins.sbt, quickstart/mongo-online-impl/project/Dependencies.scala Removed SBT version declarations and plugin/dependency configuration files from both main project and quickstart subproject.
project/FolderCleaner.scala, project/ThriftGen.scala, project/VersionDependency.scala,
quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/ChrononMongoOnlineImpl.scala, .../Constants.scala, .../MongoKvStore.scala,
.../MongoLoggingDumper.scala, .../QuickstartMutationDecoder.scala, .../Spark2MongoLoader.scala
Deleted various source code files for folder cleaning, Thrift generation, version dependency management, and MongoDB online functionalities.

Possibly related PRs

Suggested reviewers

  • piyush-zlai
  • chewy-zlai

Poem

Amidst the code, old files take flight,
Deleted paths make the repo light.
Docker dreams and configs redefined,
Node modules now neatly aligned.
Out with the old and in with the new—
A cleaner codebase shines through!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 1be90a3 and 2f660eb.

⛔ Files ignored due to path filters (11)
  • email_reply_example.png is excluded by !**/*.png
  • email_voting_example.png is excluded by !**/*.png
  • intellij_unit_test_1.png is excluded by !**/*.png
  • intellij_unit_test_2.png is excluded by !**/*.png
  • intellij_unit_test_3.png is excluded by !**/*.png
  • plugins/vscode/images/icon.png is excluded by !**/*.png
  • proposals/images/CHIP-1-current-fetcher-sequence.png is excluded by !**/*.png
  • proposals/images/CHIP-1-data-in-kv-store.png is excluded by !**/*.png
  • proposals/images/CHIP-1-new-fetcher-sequence.png is excluded by !**/*.png
  • roles.png is excluded by !**/*.png
  • vote_tally.png is excluded by !**/*.png
📒 Files selected for processing (34)
  • .gitignore (1 hunks)
  • .plugin-versions (0 hunks)
  • .scalafix.conf (0 hunks)
  • .tool-versions (0 hunks)
  • AUTHORS (0 hunks)
  • CONTRIBUTING.md (0 hunks)
  • GOVERNANCE.md (0 hunks)
  • LICENSE (0 hunks)
  • docker-compose.yml (0 hunks)
  • docker-init/README.md (1 hunks)
  • project/FolderCleaner.scala (0 hunks)
  • project/ThriftGen.scala (0 hunks)
  • project/VersionDependency.scala (0 hunks)
  • project/build.properties (0 hunks)
  • project/plugins.sbt (0 hunks)
  • proposals/CHIP-1.md (0 hunks)
  • quickstart/.env.spark (0 hunks)
  • quickstart/Dockerfile (0 hunks)
  • quickstart/README.md (0 hunks)
  • quickstart/conf/spark-defaults.conf (0 hunks)
  • quickstart/mongo-online-impl/.gitignore (0 hunks)
  • quickstart/mongo-online-impl/build.sbt (0 hunks)
  • quickstart/mongo-online-impl/project/Dependencies.scala (0 hunks)
  • quickstart/mongo-online-impl/project/build.properties (0 hunks)
  • quickstart/mongo-online-impl/project/plugins.sbt (0 hunks)
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/ChrononMongoOnlineImpl.scala (0 hunks)
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/Constants.scala (0 hunks)
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/MongoKvStore.scala (0 hunks)
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/MongoLoggingDumper.scala (0 hunks)
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/QuickstartMutationDecoder.scala (0 hunks)
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/Spark2MongoLoader.scala (0 hunks)
  • quickstart/mongo-online-impl/src/main/scala/resources/logback.xml (0 hunks)
  • quickstart/requirements.txt (0 hunks)
  • scripts/cloud_gcp_quickstart/gcp-docker-compose.yml (2 hunks)
💤 Files with no reviewable changes (31)
  • project/FolderCleaner.scala
  • project/build.properties
  • LICENSE
  • quickstart/mongo-online-impl/src/main/scala/resources/logback.xml
  • quickstart/mongo-online-impl/project/Dependencies.scala
  • quickstart/mongo-online-impl/build.sbt
  • quickstart/conf/spark-defaults.conf
  • .plugin-versions
  • quickstart/mongo-online-impl/project/build.properties
  • quickstart/mongo-online-impl/.gitignore
  • quickstart/.env.spark
  • CONTRIBUTING.md
  • quickstart/README.md
  • quickstart/Dockerfile
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/MongoLoggingDumper.scala
  • docker-compose.yml
  • GOVERNANCE.md
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/MongoKvStore.scala
  • project/VersionDependency.scala
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/Spark2MongoLoader.scala
  • .scalafix.conf
  • .tool-versions
  • proposals/CHIP-1.md
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/QuickstartMutationDecoder.scala
  • AUTHORS
  • project/ThriftGen.scala
  • project/plugins.sbt
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/ChrononMongoOnlineImpl.scala
  • quickstart/mongo-online-impl/src/main/scala/ai/chronon/quickstart/online/Constants.scala
  • quickstart/mongo-online-impl/project/plugins.sbt
  • quickstart/requirements.txt
✅ Files skipped from review due to trivial changes (2)
  • docker-init/README.md
  • .gitignore
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: scala_compile_fmt_fix
  • GitHub Check: enforce_triggered_workflows
🔇 Additional comments (2)
scripts/cloud_gcp_quickstart/gcp-docker-compose.yml (2)

29-29: Update Dockerfile path for load-serving-data.
Path now correctly points two directories up.


54-54: Update Dockerfile path for app service.
Path updated to ../../Dockerfile as intended.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@tchow-zlai tchow-zlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Collaborator

@tchow-zlai tchow-zlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we just get rid of distribution so that the scripts just live under scripts/?

@nikhil-zlai nikhil-zlai merged commit 938d8e7 into main Feb 27, 2025
5 checks passed
@nikhil-zlai nikhil-zlai deleted the nikhil/unused_file_cleanup branch February 27, 2025 01:01
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary
cleaning up top level dir 

## Checklist
- [ ] Added Unit Tests
- [x] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Refined version control and build settings by updating ignored paths
and tool versions.
- Removed obsolete internal configurations, tooling, and Docker build
files for a cleaner project structure.
- **Documentation**
  - Updated installation guidance links for clearer setup instructions.
- Eliminated legacy contributor, governance, and quickstart guides to
reduce clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary
cleaning up top level dir 

## Checklist
- [ ] Added Unit Tests
- [x] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Refined version control and build settings by updating ignored paths
and tool versions.
- Removed obsolete internal configurations, tooling, and Docker build
files for a cleaner project structure.
- **Documentation**
  - Updated installation guidance links for clearer setup instructions.
- Eliminated legacy contributor, governance, and quickstart guides to
reduce clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
cleaning up top level dir 

## Checklist
- [ ] Added Unit Tests
- [x] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Refined version control and build settings by updating ignored paths
and tool versions.
- Removed obsolete internal configurations, tooling, and Docker build
files for a cleaner project structure.
- **Documentation**
  - Updated installation guidance links for clearer setup instructions.
- Eliminated legacy contributor, governance, and quickstart guides to
reduce clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
cleaning up top level dir 

## Checklist
- [ ] Added Unit Tests
- [x] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Refined version control and build settings by updating ignored paths
and tool versions.
- Removed obsolete internal configurations, tooling, and Docker build
files for a cleaner project structure.
- **Documentation**
  - Updated installation guidance links for clearer setup instructions.
- Eliminated legacy contributor, governance, and quickstart guides to
reduce clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary
cleaning up top level dir 

## Cheour clientslist
- [ ] Added Unit Tests
- [x] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Refined version control and build settings by updating ignored paths
and tool versions.
- Removed obsolete internal configurations, tooling, and Doour clientser build
files for a cleaner project structure.
- **Documentation**
  - Updated installation guidance links for clearer setup instructions.
- Eliminated legacy contributor, governance, and quiour clientsstart guides to
reduce clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants