Skip to content

feat: try out temporary views in staging query #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2025
Merged

Conversation

tchow-zlai
Copy link
Collaborator

@tchow-zlai tchow-zlai commented Feb 25, 2025

Summary

  • Staging query should in theory already work for external tables without additional code changes as long as we do some setup work to pin up a view first.

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • New Features

    • Updated data queries to focus on checkout records and incorporate a new temporary view sourced from cloud storage.
  • Refactor

    • Optimized initialization by deferring the setup process until required, ensuring smoother operations.
  • Bug Fixes

    • Enhanced query configurations to handle missing information robustly, reducing potential runtime issues.

Copy link

coderabbitai bot commented Feb 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the SQL query and staging setup in the Python file to focus on checkout data instead of purchase data. The query now selects return_id and refund_amt from a different table and includes a new temporary view setup. Additionally, two Scala files have been modified: one updates a variable from an eager to a lazy initialization, and the other enhances null safety in engine type checking.

Changes

File(s) Change Summary
api/py/test/.../checkouts_external.py SQL query modified to select return_id and refund_amt from checkouts_external instead of purchase details; StagingQuery instantiation now uses name='checkouts_staging_query' and adds a new setups parameter to create a temporary view using a Parquet file.
spark/src/main/scala/ai/chronon/spark/Driver.scala Changed fetchContext from an eagerly evaluated val to a lazy val, deferring its initialization until first accessed.
spark/src/main/scala/ai/chronon/spark/StagingQuery.scala Modified the engine type check in computeStagingQuery to wrap the value in an Option and use getOrElse, defaulting to EngineType.SPARK to prevent NullPointerExceptions.

Sequence Diagram(s)

sequenceDiagram
    participant SQ as StagingQuery Instance
    participant TV as Temporary View Setup
    participant DB as Data Source
    SQ->>TV: Execute "CREATE OR REPLACE TEMPORARY VIEW" command
    TV-->>SQ: Temporary view created
    SQ->>DB: Execute updated SQL query on "checkouts_external"
    DB-->>SQ: Return query results
Loading

Suggested reviewers

  • nikhil-zlai
  • piyush-zlai
  • varant-zlai

Poem

In the realm of code, a change takes flight,
Checkout data gleams with renewed light.
Lazy initialization wakes on demand,
Safe checks ensure our engines withstand.
A dance of queries and views so bright.
🚀✨ CodeRabbit leaps with might!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f473147 and 510fad8.

📒 Files selected for processing (3)
  • api/py/test/sample/staging_queries/quickstart/checkouts_external.py (1 hunks)
  • spark/src/main/scala/ai/chronon/spark/Driver.scala (1 hunks)
  • spark/src/main/scala/ai/chronon/spark/StagingQuery.scala (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tchow-zlai tchow-zlai marked this pull request as draft February 25, 2025 04:25
Co-authored-by: Thomas Chow <[email protected]>
tchow-zlai and others added 3 commits February 24, 2025 20:26
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
Co-authored-by: Thomas Chow <[email protected]>
@tchow-zlai tchow-zlai marked this pull request as ready for review February 25, 2025 05:25
@tchow-zlai tchow-zlai merged commit 23279de into main Feb 25, 2025
20 of 21 checks passed
@tchow-zlai tchow-zlai deleted the tchow/stg-query-view branch February 25, 2025 05:25
kumar-zlai pushed a commit that referenced this pull request Feb 26, 2025
## Summary

- Staging query should in theory already work for external tables
without additional code changes as long as we do some setup work to pin
up a view first.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary

- Staging query should in theory already work for external tables
without additional code changes as long as we do some setup work to pin
up a view first.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary

- Staging query should in theory already work for external tables
without additional code changes as long as we do some setup work to pin
up a view first.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

- Staging query should in theory already work for external tables
without additional code changes as long as we do some setup work to pin
up a view first.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary

- Staging query should in theory already work for external tables
without additional code changes as long as we do some setup work to pin
up a view first.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary

- Staging query should in theory already work for external tables
without additional code changes as long as we do some setup work to pin
up a view first.

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to traour clients
the status of staour clientss when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: Thomas Chow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants