Cache table permission check #377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the table creation process to return clear, detailed statuses, improving feedback during table building. - Introduced a new method for generating table builders that integrates with BigQuery, including error handling for partitioning. - Streamlined data writing operations to cloud storage with automatic path configuration and Parquet integration. - Added explicit partitioning for DataFrame saves in Hive, Delta, and Iceberg formats. - **Refactor** - Overhauled logic to enforce partition restrictions and incorporate robust error handling for a smoother user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: tchow-zlai <[email protected]> Co-authored-by: Thomas Chow <[email protected]>
WalkthroughThe changes modify the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant T as checkTablePermission
participant S as SparkSession
participant DF as DataFrame
U->>T: Invoke checkTablePermission
T->>S: load(tableName)
S-->>T: Return DataFrame
T->>DF: cache()
T->>DF: collect()
alt Exception Occurs
DF-->>T: Throw error
T->>T: Log error
end
T-->>U: Return Boolean
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
spark/src/main/scala/ai/chronon/spark/TableUtils.scala(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: spark_tests
- GitHub Check: enforce_triggered_workflows
Comment on lines
+267
to
+272
| val df = sparkSession.read | ||
| .load(DataPointer.from(tableName, sparkSession)) | ||
| .where(s"$partitionColumn='$partitionFilter'") | ||
| .limit(1) | ||
| .collect() | ||
| df.cache | ||
| df.collect() |
There was a problem hiding this comment.
Clear the cache after use to prevent memory leaks.
The DataFrame is cached but never uncached, which could lead to memory pressure.
Apply this diff:
- val df = sparkSession.read
- .load(DataPointer.from(tableName, sparkSession))
- .where(s"$partitionColumn='$partitionFilter'")
- .limit(1)
- df.cache
- df.collect()
+ val df = sparkSession.read
+ .load(DataPointer.from(tableName, sparkSession))
+ .where(s"$partitionColumn='$partitionFilter'")
+ .limit(1)
+ try {
+ df.cache()
+ df.collect()
+ } finally {
+ df.unpersist()
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| val df = sparkSession.read | |
| .load(DataPointer.from(tableName, sparkSession)) | |
| .where(s"$partitionColumn='$partitionFilter'") | |
| .limit(1) | |
| .collect() | |
| df.cache | |
| df.collect() | |
| val df = sparkSession.read | |
| .load(DataPointer.from(tableName, sparkSession)) | |
| .where(s"$partitionColumn='$partitionFilter'") | |
| .limit(1) | |
| try { | |
| df.cache() | |
| df.collect() | |
| } finally { | |
| df.unpersist() | |
| } |
tchow-zlai
reviewed
Feb 14, 2025
| .load(DataPointer.from(tableName, sparkSession)) | ||
| .where(s"$partitionColumn='$partitionFilter'") | ||
| .limit(1) | ||
| .collect() | ||
| df.cache |
There was a problem hiding this comment.
let's combine with #376
|
i think @tchow-zlai removed them |
tchow-zlai
reviewed
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Summary by CodeRabbit