Bump Flink Task Manager direct memory

[piyush-zlai]

Summary

While running our Flink jobs we do see periodic restarts as we're low on direct memory. Direct mem is required by Kafka consumer clients as well as BigTable's client sdk. Flink's default seems to be 0 bytes. Bumping this a bit to 1G seems to result in the jobs running without restarting every hour.

Before:

After:

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• New Features
  • Improved memory allocation for job processing, allocating additional off-heap memory to enhance performance and reliability for applications with high memory demands.

[coderabbitai]

Walkthrough

A new configuration property is introduced in the buildFlinkJob method of the DataprocSubmitter class. The change sets the off-heap memory for tasks to "1G" without altering error handling, control flow, or other functionalities related to job submission, monitoring, and cancellation.

Changes

File Path	Summary
cloud_gcp/.../DataprocSubmitter.scala	Added taskmanager.memory.task.off-heap.size set to "1G" in the buildFlinkJob method

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant D as DataprocSubmitter
    participant F as Flink Config
    C->>D: Submit Flink job
    D->>F: Build job configuration (off-heap = "1G")
    F-->>D: Return configuration
    D-->>C: Confirm job submission

Loading

Possibly related PRs

• First cut at some prod friendly Flink settings for our Flink apps #226: Similar enhancements to the Flink job configuration in the buildFlinkJob method.

Suggested reviewers

• nikhil-zlai
• tchow-zlai

Poem

Off-heap memory now set to "1G",
A tweak in code so crisp and free.
Flink jobs fire with optimized might,
In streamlined steps, they take flight.
Cheers to progress in every byte!
🎉🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between dfc8f31 and 50e924f.

📒 Files selected for processing (1)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: scala_compile_fmt_fix
• GitHub Check: non_spark_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (1)

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala (1)

136-137: LGTM! Well-documented memory configuration.

The addition of 1G off-heap memory aligns with the PR objective to address direct memory issues for Kafka and key-value store operations.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.