Skip to content

some chart stylings to match the old version #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2025
Merged

some chart stylings to match the old version #351

merged 6 commits into from
Feb 10, 2025

Conversation

ken-zlai
Copy link
Contributor

@ken-zlai ken-zlai commented Feb 7, 2025

Summary

Couple of changes to get my feet wet with LayerChart and bring the chart styles closer to what they were using ECharts.

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • New Features

    • Enhanced chart interactivity with improved tooltip behavior and legend styling for a smoother, more engaging visualization experience.
    • Added customizable options for axis configurations and highlighted points, allowing for a more refined display of data trends.
  • Chores

    • Updated a core charting dependency to its latest version, contributing to improved performance and stability.

Copy link

coderabbitai bot commented Feb 7, 2025

Walkthrough

This PR updates the layerchart dependency version in the frontend package, enhances the FeaturesLineChart component with improved legend styling and tooltip interactivity (including mouseenter/leave events), and augments chart configuration in common utilities by adding axis properties and refining highlight settings.

Changes

Files Change Summary
frontend/package.json Updated "layerchart" dependency from ^0.93.9 to ^0.95.0.
frontend/src/lib/components/.../FeaturesLineChart.svelte
frontend/src/lib/components/.../common.ts
Enhanced chart interactivity and styling: Added extra classes in legend, introduced hideDelay for tooltips with hover events in the Svelte component, and added new axis props with updated highlight properties in common.ts.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant FC as FeaturesLineChart
    participant HL as setHighlightSeriesKey

    U->>FC: Hover over tooltip button
    FC->>HL: Call setHighlightSeriesKey(key)
    HL-->>FC: Highlight series
    U->>FC: Remove hover from tooltip button
    FC->>HL: Call setHighlightSeriesKey(null)
    HL-->>FC: Remove highlight
Loading

Possibly related PRs

Poem

In our code garden a tweak unfolds,
Legends and tooltips now shine in gold.
Axis set with care and highlights clear,
A vibrant charting story starts here.
Cheers to progress and syntax cheer! 🎉

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 6ee1dac and 65fe544.

⛔ Files ignored due to path filters (1)
  • frontend/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • frontend/package.json (1 hunks)
  • frontend/src/lib/components/charts/FeaturesLineChart.svelte (3 hunks)
  • frontend/src/lib/components/charts/common.ts (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • frontend/package.json
🔇 Additional comments (6)
frontend/src/lib/components/charts/common.ts (3)

26-38: LGTM: Consistent axis styling

Neutral colors and small text size maintain visual consistency.


60-66: LGTM: Clear highlight point configuration

Point size and stroke width are well-defined.


81-83: LGTM: Proper axis integration

Axis properties correctly integrated into line chart config.

frontend/src/lib/components/charts/FeaturesLineChart.svelte (3)

54-62: LGTM: Enhanced legend styling

Rounded swatches and consistent text sizing improve visual appeal.


67-67: LGTM: Smooth tooltip behavior

150ms hide delay prevents flickering.


106-107: LGTM: Interactive tooltip highlighting

Mouse events enhance series visibility.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sean-zlai
Copy link
Contributor

@ken-zlai overriding highlight points props while retaining series colors and other defaults is fixed in LayerChart 0.94.1

@ken-zlai ken-zlai marked this pull request as ready for review February 10, 2025 20:21
@ken-zlai ken-zlai requested a review from sean-zlai February 10, 2025 20:21
Copy link
Contributor

@sean-zlai sean-zlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great usability improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants