-
Notifications
You must be signed in to change notification settings - Fork 0
some chart stylings to match the old version #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR updates the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant FC as FeaturesLineChart
participant HL as setHighlightSeriesKey
U->>FC: Hover over tooltip button
FC->>HL: Call setHighlightSeriesKey(key)
HL-->>FC: Highlight series
U->>FC: Remove hover from tooltip button
FC->>HL: Call setHighlightSeriesKey(null)
HL-->>FC: Remove highlight
Possibly related PRs
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (6)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Great usability improvements
Summary
Couple of changes to get my feet wet with LayerChart and bring the chart styles closer to what they were using ECharts.
Checklist
Summary by CodeRabbit
New Features
Chores