Skip to content

Use Flink bazel artifacts for uploads #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

piyush-zlai
Copy link
Contributor

@piyush-zlai piyush-zlai commented Feb 7, 2025

Summary

Tested on the Etsy side and we've fixed some things in the Flink bazel deps which requires us to move off sbt.

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Chores
    • Updated the stream processing job configuration to reference a production-ready deployment artifact.
    • Streamlined the artifact generation process with an improved build mechanism for more robust deployments.

Copy link
Contributor

coderabbitai bot commented Feb 7, 2025

Walkthrough

This pull request updates the default Flink JAR file name in the run script and switches the build system for the JAR from SBT to Bazel. The constant value in the Python file is modified, and the build-and-upload script now uses a Bazel command with an updated JAR path. The overall functionality remains unchanged, focusing solely on build configuration updates.

Changes

File(s) Change Summary
api/py/ai/chronon/.../run.py Updated constant ZIPLINE_FLINK_JAR_DEFAULT from "flink-assembly-0.1.0-SNAPSHOT.jar" to "flink_assembly_deploy.jar".
distribution/build_and_upload_gcp_artifacts.sh Removed the sbt build command; added Bazel build command and updated FLINK_JAR path accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant U as User/CI
    participant S as Build Script
    participant B as Bazel
    participant G as GCS

    U->>S: Trigger build process
    S->>B: Run "bazel build //flink:flink_assembly_deploy.jar"
    B-->>S: Return JAR artifact path
    S->>G: Upload artifact using updated path
    G-->>S: Confirm upload
Loading

Possibly related PRs

Suggested reviewers

  • kumar-zlai
  • nikhil-zlai
  • tchow-zlai

Poem

In code we trust, a shift today,
From snapshot jars to deploy we sway.
Bazel builds shine bright and clear,
With new commands, our path is here.
Cheers to change – let progress steer!
🚀✨

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 54f3f97 and 90891bb.

📒 Files selected for processing (2)
  • api/py/ai/chronon/repo/run.py (1 hunks)
  • distribution/build_and_upload_gcp_artifacts.sh (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • api/py/ai/chronon/repo/run.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: non_spark_tests
  • GitHub Check: enforce_triggered_workflows
🔇 Additional comments (2)
distribution/build_and_upload_gcp_artifacts.sh (2)

46-46: Switch to Bazel for Flink assembly build
The new Bazel command for building the Flink assembly looks correct. Make sure the artifact is generated at the expected path.


50-50: Update FLINK_JAR reference
The FLINK_JAR variable now points to the Bazel output directory, which is consistent with the new build command. Verify that downstream scripts use this updated path.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@piyush-zlai piyush-zlai merged commit d24ae6a into main Feb 7, 2025
6 checks passed
@piyush-zlai piyush-zlai deleted the piyush/use_flink_artifacts branch February 7, 2025 21:59
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary
Tested on the Etsy side and we've fixed some things in the Flink bazel
deps which requires us to move off sbt.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [X] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the stream processing job configuration to reference a
production-ready deployment artifact.
- Streamlined the artifact generation process with an improved build
mechanism for more robust deployments.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary
Tested on the Etsy side and we've fixed some things in the Flink bazel
deps which requires us to move off sbt.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [X] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the stream processing job configuration to reference a
production-ready deployment artifact.
- Streamlined the artifact generation process with an improved build
mechanism for more robust deployments.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
Tested on the our clients side and we've fixed some things in the Flink bazel
deps which requires us to move off sbt.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [X] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the stream processing job configuration to reference a
production-ready deployment artifact.
- Streamlined the artifact generation process with an improved build
mechanism for more robust deployments.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
Tested on the our clients side and we've fixed some things in the Flink bazel
deps which requires us to move off sbt.

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [X] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the stream processing job configuration to reference a
production-ready deployment artifact.
- Streamlined the artifact generation process with an improved build
mechanism for more robust deployments.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary
Tested on the our clients side and we've fixed some things in the Flink bazel
deps which requires us to move off sbt.

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [X] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the stream processing job configuration to reference a
production-ready deployment artifact.
- Streamlined the artifact generation process with an improved build
mechanism for more robust deployments.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants