-
Notifications
You must be signed in to change notification settings - Fork 0
Use Flink bazel artifacts for uploads #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the default Flink JAR file name in the run script and switches the build system for the JAR from SBT to Bazel. The constant value in the Python file is modified, and the build-and-upload script now uses a Bazel command with an updated JAR path. The overall functionality remains unchanged, focusing solely on build configuration updates. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User/CI
participant S as Build Script
participant B as Bazel
participant G as GCS
U->>S: Trigger build process
S->>B: Run "bazel build //flink:flink_assembly_deploy.jar"
B-->>S: Return JAR artifact path
S->>G: Upload artifact using updated path
G-->>S: Confirm upload
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
## Summary Tested on the Etsy side and we've fixed some things in the Flink bazel deps which requires us to move off sbt. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [X] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the stream processing job configuration to reference a production-ready deployment artifact. - Streamlined the artifact generation process with an improved build mechanism for more robust deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Tested on the Etsy side and we've fixed some things in the Flink bazel deps which requires us to move off sbt. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [X] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the stream processing job configuration to reference a production-ready deployment artifact. - Streamlined the artifact generation process with an improved build mechanism for more robust deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Tested on the our clients side and we've fixed some things in the Flink bazel deps which requires us to move off sbt. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [X] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the stream processing job configuration to reference a production-ready deployment artifact. - Streamlined the artifact generation process with an improved build mechanism for more robust deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Tested on the our clients side and we've fixed some things in the Flink bazel deps which requires us to move off sbt. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [X] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the stream processing job configuration to reference a production-ready deployment artifact. - Streamlined the artifact generation process with an improved build mechanism for more robust deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Tested on the our clients side and we've fixed some things in the Flink bazel deps which requires us to move off sbt. ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [X] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the stream processing job configuration to reference a production-ready deployment artifact. - Streamlined the artifact generation process with an improved build mechanism for more robust deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Tested on the Etsy side and we've fixed some things in the Flink bazel deps which requires us to move off sbt.
Checklist
Summary by CodeRabbit