Conditionally download jars only if hashes do not match #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes enhance file download functionality by integrating integrity checks. New functions calculate hash values for both remote (GCS) and local files, comparing them before initiating a download. Existing download functions now check if the local file matches the GCS version to avoid redundant downloads. Additionally, the use of a fixed storage location (ZIPLINE_DIRECTORY) replaces the prior temporary directory mechanism. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Downloader
participant LocalStore as "Local Storage"
participant GCS as "Google Cloud Storage"
Client->>Downloader: Request file download
Downloader->>LocalStore: Compute local file hash
Downloader->>GCS: Retrieve remote file hash
Downloader->>Downloader: Compare hash values
alt Hashes match
Downloader->>Client: Notify file up-to-date (skip download)
else Hashes differ
Downloader->>GCS: Download updated file
Downloader->>LocalStore: Save file to ZIPLINE_DIRECTORY
Downloader->>Client: Confirm download completion
end
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
api/py/ai/chronon/repo/run.py (2)
900-913: Repetitive download code.
Consider consolidating to reduce duplication.
924-938: Similarly duplicated jar download logic.
Extract into a helper function for maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
api/py/ai/chronon/repo/run.py(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: non_spark_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (6)
api/py/ai/chronon/repo/run.py (6)
21-21: No concerns with the new import.
23-23: Verify dependency is properly included.
Ensure the environment has google-crc32c installed and pinned if needed.
139-139: Potential ephemeral directory concern.
Using /tmp might risk data loss on system cleanup. Confirm if that’s intended.
875-888: Good logic for conditional download.
Checks local hash vs GCS before downloading. Looks correct.
975-1034: Hashing functions are properly structured.
They accurately compute and compare CRC32C values.
1085-1096: Clear fallback logic for jar selection.
Implementation is straightforward and flexible.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
api/py/ai/chronon/repo/run.py (2)
140-140: Consider using a configurable directory path.Hard-coding
/tmp/ziplinemight not work in all environments. Consider making it configurable via environment variable.-ZIPLINE_DIRECTORY = "/tmp/zipline" +ZIPLINE_DIRECTORY = os.environ.get('ZIPLINE_DIRECTORY', '/tmp/zipline')
868-889: Add return type hint.Function is missing return type annotation.
-def download_zipline_jar(destination_dir: str, customer_id: str, jar_name: str): +def download_zipline_jar(destination_dir: str, customer_id: str, jar_name: str) -> str:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
api/py/ai/chronon/repo/run.py(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: non_spark_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (2)
api/py/ai/chronon/repo/run.py (2)
926-984: Well-implemented hash comparison functions!The implementation is robust with proper error handling, efficient file reading in chunks, and clear documentation.
1035-1044: LGTM! Clean implementation of JAR download logic.The directory creation and JAR path construction are well-handled.
tchow-zlai
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
api/py/ai/chronon/repo/run.py (2)
868-889: Add retry mechanism and improve path handling.The function lacks retry capability and uses string concatenation for paths.
+@retry_decorator(retries=2, backoff=5) def download_zipline_jar(destination_dir: str, customer_id: str, jar_name: str): bucket_name = f"zipline-artifacts-{customer_id}" - source_blob_name = f"jars/{jar_name}" - destination_path = f"{destination_dir}/{jar_name}" + source_blob_name = os.path.join("jars", jar_name) + destination_path = os.path.join(destination_dir, jar_name)
1035-1035: Handle directory creation errors.Add explicit error handling for directory creation.
- os.makedirs(ZIPLINE_DIRECTORY, exist_ok=True) + try: + os.makedirs(ZIPLINE_DIRECTORY, exist_ok=True) + except PermissionError as e: + raise RuntimeError(f"Cannot create directory {ZIPLINE_DIRECTORY}: Permission denied") from e
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
api/py/ai/chronon/repo/run.py(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: non_spark_tests
- GitHub Check: enforce_triggered_workflows
Comment on lines
+961
to
+984
| def compare_gcs_and_local_file_hashes(bucket_name: str, blob_name: str, local_file_path: str) -> bool: | ||
| """ | ||
| Compare hashes of a GCS file and a local file to check if they're identical. | ||
|
|
||
| Args: | ||
| bucket_name: Name of the GCS bucket | ||
| blob_name: Name/path of the blob in the bucket | ||
| local_file_path: Path to the local file | ||
|
|
||
| Returns: | ||
| True if files are identical, False otherwise | ||
| """ | ||
| try: | ||
| gcs_hash = get_gcs_file_hash(bucket_name, blob_name) | ||
| local_hash = get_local_file_hash(local_file_path) | ||
|
|
||
| print(f"Local hash of {local_file_path}: {local_hash}. GCS file {blob_name} hash: {gcs_hash}") | ||
|
|
||
| return gcs_hash == local_hash | ||
|
|
||
| except Exception as e: | ||
| print(f"Error comparing files: {str(e)}") | ||
| return False | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve error handling in hash comparison.
The function silently returns False on errors, which could mask issues like permission problems or network errors.
- except Exception as e:
- print(f"Error comparing files: {str(e)}")
- return False
+ except FileNotFoundError as e:
+ print(f"File not found error: {str(e)}")
+ return False
+ except (storage.exceptions.NotFound, storage.exceptions.Forbidden) as e:
+ print(f"GCS error: {str(e)}")
+ return False
+ except Exception as e:
+ print(f"Unexpected error comparing files: {str(e)}")
+ raise📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| def compare_gcs_and_local_file_hashes(bucket_name: str, blob_name: str, local_file_path: str) -> bool: | |
| """ | |
| Compare hashes of a GCS file and a local file to check if they're identical. | |
| Args: | |
| bucket_name: Name of the GCS bucket | |
| blob_name: Name/path of the blob in the bucket | |
| local_file_path: Path to the local file | |
| Returns: | |
| True if files are identical, False otherwise | |
| """ | |
| try: | |
| gcs_hash = get_gcs_file_hash(bucket_name, blob_name) | |
| local_hash = get_local_file_hash(local_file_path) | |
| print(f"Local hash of {local_file_path}: {local_hash}. GCS file {blob_name} hash: {gcs_hash}") | |
| return gcs_hash == local_hash | |
| except Exception as e: | |
| print(f"Error comparing files: {str(e)}") | |
| return False | |
| def compare_gcs_and_local_file_hashes(bucket_name: str, blob_name: str, local_file_path: str) -> bool: | |
| """ | |
| Compare hashes of a GCS file and a local file to check if they're identical. | |
| Args: | |
| bucket_name: Name of the GCS bucket | |
| blob_name: Name/path of the blob in the bucket | |
| local_file_path: Path to the local file | |
| Returns: | |
| True if files are identical, False otherwise | |
| """ | |
| try: | |
| gcs_hash = get_gcs_file_hash(bucket_name, blob_name) | |
| local_hash = get_local_file_hash(local_file_path) | |
| print(f"Local hash of {local_file_path}: {local_hash}. GCS file {blob_name} hash: {gcs_hash}") | |
| return gcs_hash == local_hash | |
| except FileNotFoundError as e: | |
| print(f"File not found error: {str(e)}") | |
| return False | |
| except (storage.exceptions.NotFound, storage.exceptions.Forbidden) as e: | |
| print(f"GCS error: {str(e)}") | |
| return False | |
| except Exception as e: | |
| print(f"Unexpected error comparing files: {str(e)}") | |
| raise |
4 tasks
4 tasks
4 tasks
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 25, 2025
## Summary Tested locally. Tested when file doesn't exist for the first time (it downloads), and then rerunning and seeing script not download since file hashes are the same. ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill .... /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` Tested when file changes: ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: NWH0FQ==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the file download process by adding integrity checks, ensuring that files are only downloaded when updates are detected. - **Chores** - Streamlined file management by moving downloads to a dedicated, consistent folder, improving overall efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai
pushed a commit
that referenced
this pull request
Apr 29, 2025
## Summary Tested locally. Tested when file doesn't exist for the first time (it downloads), and then rerunning and seeing script not download since file hashes are the same. ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill .... /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` Tested when file changes: ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: NWH0FQ==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the file download process by adding integrity checks, ensuring that files are only downloaded when updates are detected. - **Chores** - Streamlined file management by moving downloads to a dedicated, consistent folder, improving overall efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary Tested locally. Tested when file doesn't exist for the first time (it downloads), and then rerunning and seeing script not download since file hashes are the same. ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill .... /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` Tested when file changes: ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: NWH0FQ==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the file download process by adding integrity checks, ensuring that files are only downloaded when updates are detected. - **Chores** - Streamlined file management by moving downloads to a dedicated, consistent folder, improving overall efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary Tested locally. Tested when file doesn't exist for the first time (it downloads), and then rerunning and seeing script not download since file hashes are the same. ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill .... /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` Tested when file changes: ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: NWH0FQ==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from bucket zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode backfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the file download process by adding integrity checks, ensuring that files are only downloaded when updates are detected. - **Chores** - Streamlined file management by moving downloads to a dedicated, consistent folder, improving overall efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
## Summary Tested locally. Tested when file doesn't exist for the first time (it downloads), and then rerunning and seeing script not download since file hashes are the same. ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode baour clientsfill .... /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from buour clientset zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode baour clientsfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` Tested when file changes: ``` (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode baour clientsfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: NWH0FQ==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar does NOT match GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar Downloading dataproc submitter jar from GCS... Downloaded storage object jars/cloud_gcp_submitter_deploy.jar from buour clientset zipline-artifacts-canary to local file /tmp/zipline/cloud_gcp_submitter_deploy.jar. (dev_chronon) davidhan@Davids-MacBook-Pro: ~/zipline/chronon/api/py/test/sample (davidhan/conditionally_download_jar) $ python $RUN_PY --mode baour clientsfill ... Local hash of /tmp/zipline/cloud_gcp_submitter_deploy.jar: 0lEgxw==. GCS file jars/cloud_gcp_submitter_deploy.jar hash: 0lEgxw== /tmp/zipline/cloud_gcp_submitter_deploy.jar matches GCS zipline-artifacts-canary/jars/cloud_gcp_submitter_deploy.jar ``` ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the file download process by adding integrity cheour clientss, ensuring that files are only downloaded when updates are detected. - **Chores** - Streamlined file management by moving downloads to a dedicated, consistent folder, improving overall efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tested locally.
Tested when file doesn't exist for the first time (it downloads), and then rerunning and seeing script not download since file hashes are the same.
Tested when file changes:
Checklist
Summary by CodeRabbit