Skip to content

feat: add a workflow to poll other workflows for branch protection #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

feat: add a workflow to poll other workflows for branch protection #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
506dc8f
feat: add a workflow to poll other workflows for branch protection
tchow-zlai Jan 28, 2025
72de6db
change name
tchow-zlai Jan 28, 2025
4b5769f
typo
tchow-zlai Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/require_triggered_status_checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: branch_protection
on:
pull_request:
jobs:
enforce_triggered_workflows:
runs-on: ubuntu-latest
permissions:
checks: read
steps:
- name: GitHub Checks
uses: poseidon/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}
42 changes: 25 additions & 17 deletions cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitterTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ class DataprocSubmitterTest extends AnyFlatSpec with MockitoSugar {

// Test starts here.

val submitter = new DataprocSubmitter(
mockJobControllerClient,
SubmitterConf("test-project", "test-region", "test-cluster"))
val submitter =
new DataprocSubmitter(mockJobControllerClient, SubmitterConf("test-project", "test-region", "test-cluster"))

val submittedJobId = submitter.submit(spark.SparkJob, Map(MainClass -> "test-main-class", JarURI -> "test-jar-uri"), List.empty)
val submittedJobId =
submitter.submit(spark.SparkJob, Map(MainClass -> "test-main-class", JarURI -> "test-jar-uri"), List.empty)
assertEquals(submittedJobId, jobId)
}

Expand All @@ -54,29 +54,36 @@ class DataprocSubmitterTest extends AnyFlatSpec with MockitoSugar {
it should "test flink job locally" ignore {

val submitter = DataprocSubmitter()
submitter.submit(spark.FlinkJob,
Map(MainClass -> "ai.chronon.flink.FlinkJob",
submitter.submit(
spark.FlinkJob,
Map(
MainClass -> "ai.chronon.flink.FlinkJob",
FlinkMainJarURI -> "gs://zipline-jars/flink-assembly-0.1.0-SNAPSHOT.jar",
JarURI -> "gs://zipline-jars/cloud_gcp_bigtable.jar"),
JarURI -> "gs://zipline-jars/cloud_gcp_bigtable.jar"
),
List.empty,
"--online-class=ai.chronon.integrations.cloud_gcp.GcpApiImpl",
"--groupby-name=e2e-count",
"-ZGCP_PROJECT_ID=bigtable-project-id",
"-ZGCP_INSTANCE_ID=bigtable-instance-id")
"-ZGCP_INSTANCE_ID=bigtable-instance-id"
)
}

it should "test flink kafka ingest job locally" ignore {

val submitter = DataprocSubmitter()
val submittedJobId =
submitter.submit(spark.FlinkJob,
Map(MainClass -> "ai.chronon.flink.FlinkKafkaBeaconEventDriver",
submitter.submit(
spark.FlinkJob,
Map(
MainClass -> "ai.chronon.flink.FlinkKafkaBeaconEventDriver",
FlinkMainJarURI -> "gs://zipline-jars/flink_kafka_ingest-assembly-0.1.0-SNAPSHOT.jar",
JarURI -> "gs://zipline-jars/cloud_gcp_bigtable.jar"),
JarURI -> "gs://zipline-jars/cloud_gcp_bigtable.jar"
),
List.empty,
"--kafka-bootstrap=bootstrap.zipline-kafka-cluster.us-central1.managedkafka.canary-443022.cloud.goog:9092",
"--kafka-topic=test-beacon-main",
"--data-file-name=gs://zl-warehouse/beacon_events/beacon-output.avro",
"--data-file-name=gs://zl-warehouse/beacon_events/beacon-output.avro"
)
println(submittedJobId)
}
Expand All @@ -88,10 +95,10 @@ class DataprocSubmitterTest extends AnyFlatSpec with MockitoSugar {
submitter.submit(
spark.SparkJob,
Map(MainClass -> "ai.chronon.spark.Driver",
JarURI -> "gs://zipline-jars/cloud_gcp-assembly-0.1.0-SNAPSHOT.jar"),
JarURI -> "gs://zipline-jars/cloud_gcp-assembly-0.1.0-SNAPSHOT.jar"),
List("gs://zipline-jars/training_set.v1",
"gs://zipline-jars/dataproc-submitter-conf.yaml",
"gs://zipline-jars/additional-confs.yaml"),
"gs://zipline-jars/dataproc-submitter-conf.yaml",
"gs://zipline-jars/additional-confs.yaml"),
"join",
"--end-date=2024-12-10",
"--additional-conf-path=additional-confs.yaml",
Expand All @@ -107,7 +114,7 @@ class DataprocSubmitterTest extends AnyFlatSpec with MockitoSugar {
submitter.submit(
spark.SparkJob,
Map(MainClass -> "ai.chronon.spark.Driver",
JarURI -> "gs://zipline-jars/cloud_gcp-assembly-0.1.0-SNAPSHOT.jar"),
JarURI -> "gs://zipline-jars/cloud_gcp-assembly-0.1.0-SNAPSHOT.jar"),
List.empty,
"groupby-upload-bulk-load",
"-ZGCP_PROJECT_ID=bigtable-project-id",
Expand All @@ -116,7 +123,8 @@ class DataprocSubmitterTest extends AnyFlatSpec with MockitoSugar {
"--online-class=ai.chronon.integrations.cloud_gcp.GcpApiImpl",
"--src-offline-table=data.test_gbu",
"--groupby-name=quickstart.purchases.v1",
"--partition-string=2024-01-01")
"--partition-string=2024-01-01"
)
println(submittedJobId)
assertEquals(submittedJobId, "mock-job-id")
}
Expand Down